Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on Disabled vs Enabled config to control if a component is enabled or not. #1397

Closed
bogdandrutu opened this issue Jul 17, 2020 · 1 comment · Fixed by #1433
Closed
Assignees
Labels
bug Something isn't working

Comments

@bogdandrutu
Copy link
Member

From a comment in #1386

Do we have a enabled/disabled flag already elsewhere in the project? If not, it would be best to have enabled instead of disabled: having something happening on double negatives is confusing to users (disabled: false == enabled)

@jrcamp
Copy link
Contributor

jrcamp commented Jul 22, 2020

I think enabled is the more intuitive one. We had disabled in <ComponentType>Settings before right? Is there a reason we got rid of it in the first place? The reason it was called disabled before was possibly for a matter of convenience as bool defaults to false in Go and we wanted it to default to enabled I assume.

In terms of implementation if we go with enabled:

One way to default enabled to true would be to use default tags using something like https://github.com/creasty/defaults. I'd like to start using this in a number of components going forward anyway. It would be convenient for this to just be part of general config loading in core but at the same time it's an addition to the API that must be preserved going forward. But it's not a large library in terms of code.

I'm sure there's other ways to implement it that don't require using defaults tags but it is a useful thing to have.

@bogdandrutu bogdandrutu self-assigned this Jul 24, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
…rters/metric/prometheus (open-telemetry#1397)

* Bump github.com/prometheus/client_golang in /exporters/metric/prometheus

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.7.1 to 1.8.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/master/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.7.1...v1.8.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
…y#1397)

Bumps [boto3](https://github.com/boto/boto3) from 1.21.24 to 1.21.25.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.21.24...1.21.25)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants