Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docked image naming and tagging #751

Closed
naseemkullah opened this issue Mar 30, 2020 · 7 comments
Closed

docked image naming and tagging #751

naseemkullah opened this issue Mar 30, 2020 · 7 comments

Comments

@naseemkullah
Copy link
Member

naseemkullah commented Mar 30, 2020

https://hub.docker.com/u/otel

IMHO The prepending opentelemetry- seems redundant since the repo is named otel.

Furthermore could there simply be a collector image with various tags: e.g. dev, contrib, contrib-dev, stable or are they really different and require different images altogether?

@naseemkullah naseemkullah changed the title docke image naming and tagging docked image naming and tagging Mar 30, 2020
@tigrannajaryan
Copy link
Member

https://hub.docker.com/u/otel

IMHO The prepending opentelemetry- seems redundant since the repo is named otel.

This repo is named opentelemetry-collector. It is not quite clear what your proposal is.

Furthermore could there simply be a collector image with various tags: e.g. dev, contrib, contrib-dev, stable or are they really different and require different images altogether?

Yes, they are different. dev is from master build. stable is the releases. contrib is from https://github.com/open-telemetry/opentelemetry-collector-contrib/ repo.

@naseemkullah
Copy link
Member Author

https://hub.docker.com/u/otel
IMHO The prepending opentelemetry- seems redundant since the repo is named otel.

This repo is named opentelemetry-collector. It is not quite clear what your proposal is.

That the image be otel/collector:stable instead of otel/opentelemetry-collector:stable ,
but by that logic this repo should be opentelemetry/collector rather than opentelemetry/opentelemetry-collector so 🤷‍♂️

Furthermore could there simply be a collector image with various tags: e.g. dev, contrib, contrib-dev, stable or are they really different and require different images altogether?

Yes, they are different. dev is from master build. stable is the releases. contrib is from https://github.com/open-telemetry/opentelemetry-collector-contrib/ repo.

could then dev and stable just be image tags of the same image? i.e. otel/(opentelemetry-)collector:dev and otel/(opentelemetry-)collector:stable ?

@atrauzzi
Copy link

atrauzzi commented May 7, 2020

I don't know about you guys, but otel as the organization name is flat out confusing and not even slightly discoverable.

The docker image based on this repo should be one of:

  • opentelemetry/collector
  • opentelemetry/opentelemetry-collector

This scheme works for countless other organizations. otel is just way too inside-baseball to assume people are going to know to search and recognize it as an official source. It's like putting your nickname on a government form: At a glance, it earns no legitimacy and serves no purpose but to obscure what's typically interpreted as the organization portion of the image name.

@tigrannajaryan
Copy link
Member

https://hub.docker.com/u/otel
IMHO The prepending opentelemetry- seems redundant since the repo is named otel.

This repo is named opentelemetry-collector. It is not quite clear what your proposal is.

That the image be otel/collector:stable instead of otel/opentelemetry-collector:stable ,
but by that logic this repo should be opentelemetry/collector rather than opentelemetry/opentelemetry-collector so 🤷‍♂️

Furthermore could there simply be a collector image with various tags: e.g. dev, contrib, contrib-dev, stable or are they really different and require different images altogether?

Yes, they are different. dev is from master build. stable is the releases. contrib is from https://github.com/open-telemetry/opentelemetry-collector-contrib/ repo.

could then dev and stable just be image tags of the same image? i.e. otel/(opentelemetry-)collector:dev and otel/(opentelemetry-)collector:stable ?

@dmitryax @owais any thoughts on what would be best practices for naming Dockerhub images?

@tigrannajaryan
Copy link
Member

I don't know about you guys, but otel as the organization name is flat out confusing and not even slightly discoverable.

The docker image based on this repo should be one of:

* `opentelemetry/collector`

* `opentelemetry/opentelemetry-collector`

This scheme works for countless other organizations. otel is just way too inside-baseball to assume people are going to know to search and recognize it as an official source. It's like putting your nickname on a government form: At a glance, it earns no legitimacy and serves no purpose but to obscure what's typically interpreted as the organization portion of the image name.

@atrauzzi opentelemetry Dockerhub organization is not available. See previous discussion open-telemetry/community#164

@owais
Copy link
Contributor

owais commented May 8, 2020

I think the docker image should contain the full name because the org is named otel so having opentelemetry in the name helps. Also contributors and users often build images from the repo and use them somewhere without uploading to docker hub. Having such images named just collector doesn't help. I don't have any strong opinion about the docker hub org name but I think container images should definitely continue to be opentelemetry-collector*

@tigrannajaryan
Copy link
Member

Closing as it appears there is nothing to do. Feel free to reopen if you have further comments.

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
* Checkpoint new pull controller

* Tests pass

* Fix example

* Example fix

* Add a test

* Comment

* address MrAlias's feedback
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
* Fix several links in full_agent_config.yaml

* fix all the links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants