Mark queue retry processor as deprecated. #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This was referenced Sep 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #1821 +/- ##
==========================================
- Coverage 91.12% 91.11% -0.02%
==========================================
Files 263 263
Lines 16107 16109 +2
==========================================
Hits 14677 14677
- Misses 1003 1004 +1
- Partials 427 428 +1
Continue to review full report at Codecov.
|
|
Perhaps this PR should also remove from the factories. |
|
@pavolloffay not sure, I don't want to break current configs for the user. So just printing a log message is good I think. |
tigrannajaryan
approved these changes
Sep 22, 2020
|
Let's start with a warning for now. We'll keep it for a while (a few months) and can then think about removing it completely. |
nilebox
reviewed
Oct 6, 2020
|
|
||
| Refer to [config.yaml](./testdata/config.yaml) for detailed | ||
| examples on using the processor. | ||
| QueuedRetry processor is deprecated. Use exporter queued retry config. |
There was a problem hiding this comment.
There should have been a link to an example of how to use it in the exporter config.
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* initial support for timeout on otlp grpc exporter * fix tests * run make * update changelog * update changelog * apply suggestions Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1721