Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark queue retry processor as deprecated. #1821

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

bogdandrutu
Copy link
Member

Fixes #1721

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #1821 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1821      +/-   ##
==========================================
- Coverage   91.12%   91.11%   -0.02%     
==========================================
  Files         263      263              
  Lines       16107    16109       +2     
==========================================
  Hits        14677    14677              
- Misses       1003     1004       +1     
- Partials      427      428       +1     
Impacted Files Coverage Δ
processor/queuedprocessor/factory.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 87.23% <0.00%> (-2.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab27911...d41089c. Read the comment docs.

@pavolloffay
Copy link
Member

Perhaps this PR should also remove

from the factories.

@bogdandrutu
Copy link
Member Author

@pavolloffay not sure, I don't want to break current configs for the user. So just printing a log message is good I think.

@tigrannajaryan
Copy link
Member

Let's start with a warning for now. We'll keep it for a while (a few months) and can then think about removing it completely.

@tigrannajaryan tigrannajaryan merged commit e820370 into open-telemetry:master Sep 22, 2020
@bogdandrutu bogdandrutu deleted the queret branch September 22, 2020 18:23

Refer to [config.yaml](./testdata/config.yaml) for detailed
examples on using the processor.
QueuedRetry processor is deprecated. Use exporter queued retry config.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should have been a link to an example of how to use it in the exporter config.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can review a PR :)

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* initial support for timeout on otlp grpc exporter

* fix tests

* run make

* update changelog

* update changelog

* apply suggestions

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate queue retry processor and enable queueing per exporter by default
4 participants