-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark queue retry processor as deprecated. #1821
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1821 +/- ##
==========================================
- Coverage 91.12% 91.11% -0.02%
==========================================
Files 263 263
Lines 16107 16109 +2
==========================================
Hits 14677 14677
- Misses 1003 1004 +1
- Partials 427 428 +1
Continue to review full report at Codecov.
|
Perhaps this PR should also remove
|
@pavolloffay not sure, I don't want to break current configs for the user. So just printing a log message is good I think. |
Let's start with a warning for now. We'll keep it for a while (a few months) and can then think about removing it completely. |
|
||
Refer to [config.yaml](./testdata/config.yaml) for detailed | ||
examples on using the processor. | ||
QueuedRetry processor is deprecated. Use exporter queued retry config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should have been a link to an example of how to use it in the exporter config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can review a PR :)
* initial support for timeout on otlp grpc exporter * fix tests * run make * update changelog * update changelog * apply suggestions Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Fixes #1721