Fix missing include dir for configure_package_config_file #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomsonTan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 189 189
Lines 8388 8388
=======================================
Hits 7924 7924
Misses 464 464
|
ThomsonTan
added
bug
lalitb
approved these changes
Jan 14, 2021
jsuereth
approved these changes
Jan 20, 2021
ThomsonTan
added
the
pr:please-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #513 by passing the missing
INCLUDE_INSTALL_DIRtoconfigure_package_config_fileasPATH_VARS.