Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dedicated ShutdownResult for Metric SDK shutdown #2573

Merged
merged 9 commits into from
Jan 31, 2025

Merge branch 'main' into cijothomas/metric-shutdown

8ab63bf
Select commit
Loading
Failed to load commit list.
Merged

Use dedicated ShutdownResult for Metric SDK shutdown #2573

Merge branch 'main' into cijothomas/metric-shutdown
8ab63bf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 31, 2025 in 0s

51.0% of diff hit (target 79.6%)

View this Pull Request on Codecov

51.0% of diff hit (target 79.6%)

Annotations

Check warning on line 51 in opentelemetry-otlp/src/exporter/http/metrics.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-otlp/src/exporter/http/metrics.rs#L47-L51 

Added lines #L47 - L51 were not covered by tests

Check warning on line 97 in opentelemetry-otlp/src/exporter/tonic/metrics.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-otlp/src/exporter/tonic/metrics.rs#L93-L97 

Added lines #L93 - L97 were not covered by tests

Check warning on line 153 in opentelemetry-otlp/src/metric.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-otlp/src/metric.rs#L153 

Added line #L153 was not covered by tests

Check warning on line 116 in opentelemetry-sdk/src/metrics/manual_reader.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-sdk/src/metrics/manual_reader.rs#L113-L116 

Added lines #L113 - L116 were not covered by tests

Check warning on line 419 in opentelemetry-sdk/src/metrics/periodic_reader.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-sdk/src/metrics/periodic_reader.rs#L419 

Added line #L419 was not covered by tests

Check warning on line 423 in opentelemetry-sdk/src/metrics/periodic_reader.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-sdk/src/metrics/periodic_reader.rs#L423 

Added line #L423 was not covered by tests

Check warning on line 426 in opentelemetry-sdk/src/metrics/periodic_reader.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-sdk/src/metrics/periodic_reader.rs#L426 

Added line #L426 was not covered by tests

Check warning on line 299 in opentelemetry-sdk/src/metrics/periodic_reader_with_async_runtime.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-sdk/src/metrics/periodic_reader_with_async_runtime.rs#L299 

Added line #L299 was not covered by tests

Check warning on line 387 in opentelemetry-sdk/src/metrics/periodic_reader_with_async_runtime.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-sdk/src/metrics/periodic_reader_with_async_runtime.rs#L387 

Added line #L387 was not covered by tests

Check warning on line 666 in opentelemetry-sdk/src/metrics/pipeline.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-sdk/src/metrics/pipeline.rs#L664-L666 

Added lines #L664 - L666 were not covered by tests

Check warning on line 68 in opentelemetry-stdout/src/metrics/exporter.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-stdout/src/metrics/exporter.rs#L68 

Added line #L68 was not covered by tests
View more details on Codecov