Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update architecture.md to remove incompatible link notation from diagram #5175

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Update architecture.md to remove incompatible link notation from diagram #5175

merged 1 commit into from
Sep 11, 2024

Conversation

theletterf
Copy link
Member

Fixes #5168

@theletterf theletterf requested a review from a team September 10, 2024 08:10
@opentelemetrybot opentelemetrybot requested a review from a team September 10, 2024 08:10
mviitane
mviitane approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mviitane
Copy link
Member

Not directly related to this PR, but this Telemetry Data Flow image looks too large compared to the Service Diagram (on the same page). Is there any setting for that?

@theletterf
Copy link
Member Author

@mviitane We'd only control that through CSS classes, I'm afraid. Could you post a screenshot and your screen res?

@mviitane
Copy link
Member

@mviitane We'd only control that through CSS classes, I'm afraid. Could you post a screenshot and your screen res?

I have 2560 x 1440 screens, but in this screenshot, I'm using a somewhat narrow browser window. The font in the lower picture is much bigger than the upper pic (similar font size would work better). Also, the lower picture is so high that I cannot fit it on the screen at once.
Screenshot 2024-09-10 at 12 49 55

@monteiro-renato
Copy link
Contributor

FYI: Looks like it's not completely fixed yet:
bilde

@theletterf
Copy link
Member Author

Let's merge till the bug gets fixed in Mermaid.

@theletterf theletterf added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 4a2ebb3 Sep 11, 2024
19 checks passed
@theletterf theletterf deleted the theletterf-patch-1 branch September 11, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffany76 tiffany76 tiffany76 approved these changes

@mviitane mviitane mviitane approved these changes

Assignees
No one assigned
Labels
sig:demo
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demo Architecture Diagram shows "unsupported markdown"
4 participants
@theletterf @mviitane @monteiro-renato @tiffany76