Fix the rendering of http urls in architecture.md's mermaid diagram #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@monteiro-renato Please check #5168 |
monteiro-renato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
The diagram here is currently broken > https://opentelemetry.io/docs/demo/architecture/
What I did (and I think this is probably a terrible idea) was adding a Zero-width space before the colon in the urls.
I also tested adding a and it also allows the rending to take place.
I'm not super familiar with Mermaid so there might exist a better way to do this (I hope so at least).
Raising this for awareness, if you are aware of an easy fix let me know and I can fix it quickly. Otherwise I will try to look into it whenever I have time available.