Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Switch prod API to Fineract.dev demo #1256

Merged
merged 1 commit into from
Nov 4, 2020
Merged

feat: Switch prod API to Fineract.dev demo #1256

merged 1 commit into from
Nov 4, 2020

Conversation

vorburger
Copy link
Member

@karantakalkar karantakalkar added the review requested Pull Request requiring review by senior collaborators label Oct 6, 2020
@vorburger
Copy link
Member Author

@edcable would you like to merge this, if you are OK with it? Or is there anything else required to make this switch? (Does Fineract.dev have to have more demo data before we flip the switch?!)

@vorburger vorburger mentioned this pull request Oct 21, 2020
Closed
@vorburger
Copy link
Member Author

@karantakalkar dixit on https://app.slack.com/client/T0F5GHE8Y/CJJGJLN10/thread/CJJGJLN10-1600713781.000500, quote:

will deprive the hosted instance of a lot of features as there isn't much data on dev server. I think for this reason @abhaychawla didn't update it in #803. I am still a bit reluctant because of above mentioned reason. Please merge if lack of data isn't relevant.

@edcable who can make this decision how? I could just "self merge" this PR, but shouldn't... 😈

https://issues.apache.org/jira/browse/FINERACT-1238 create to discuss "demo data" tooling in Fineract.

@abhaychawla abhaychawla removed the review requested Pull Request requiring review by senior collaborators label Nov 4, 2020
@abhaychawla abhaychawla merged commit d191d11 into master Nov 4, 2020
vorburger added a commit to vorburger/www.fineract.dev that referenced this pull request Nov 12, 2020
@vorburger
Use openmf.github.io/web-app instead of wui.fineract.dev
22bf323 
following merge of openMF/web-app#1256

https://wui.fineract.dev is now deleted.
@karantakalkar karantakalkar deleted the vorburger-patch-2 branch November 25, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vorburger @abhaychawla @karantakalkar