fix(azure): azure_deployment use with realtime + non-deployment-based APIs #2154
+637
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertCraigie
approved these changes
Feb 28, 2025
RobertCraigie
changed the title
Merged
stainless-app bot
pushed a commit
that referenced
this pull request
Mar 1, 2025
… APIs (#2154) * support realtime with azure_deployment * lint * use rsplit * switch approach: save copy of the original url * save azure_endpoint as it was given * docstring * format * remove unnecessary check + add test * fix for websocket_base_url * add another test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Resolves #2120 and #1397
When the Azure client is initialized with both
azure_endpointandazure_deployment, theazure_deploymentis added to thebase_url:openai-python/src/openai/lib/azure.py
Lines 199 to 200 in 939c861
Having the deployment hardcoded in the
base_urlcan be problematic when a non-deployments API is called, or with the realtime API (which puts the deployment in the query params instead of URL path). This PR overrides_prepare_urlto use the originalazure_endpointpassed in with cases where a non-deployment based API is being called (or realtime). It also removes themodelquery param from the realtime URL (it's not expected for Azure).Additional context & links