feat: Allow any Mapping in generated from_dict functions
#1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
from_dict_immutable
branch
from
7cb82c4 to
56e4262
Compare
edgarrmondragon
changed the title
Mapping in generated from_dictMapping in generated from_dict
edgarrmondragon
commented
Mar 3, 2025
...s/docstrings-on-attributes-golden-record/my_test_api_client/models/model_with_description.py
Show resolved
Hide resolved
dbanty
approved these changes
Mar 15, 2025
Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>
dbanty
changed the title
Mapping in generated from_dictMapping in generated from_dict functions
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 15, 2025
> [!IMPORTANT] > Merging this pull request will create this release ## Features - allow Ruff to 0.10 (#1220) - allow Ruff 0.11 (#1222) - Allow any `Mapping` in generated `from_dict` functions (#1211) ## Fixes ### Always parse `$ref` as a reference If additional attributes were included with a `$ref` (for example `title` or `description`), the property could be interpreted as a new type instead of a reference, usually resulting in `Any` in the generated code. Now, any sibling properties to `$ref` will properly be ignored, as per the OpenAPI specification. Thanks @nkrishnaswami! Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
|
Thanks @dbanty ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1203