Container must not checkpoint in created state #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rajasec <rajasec79@gmail.com>
|
LGTM |
1 similar comment
|
LGTM |
|
This PR broke |
Merged
|
@caniszczyk @crosbymichael The reason the tests didn't fail for almost a month is because the Jenkins job doesn't merge PRs onto master before running the tests. Should we change the job to do this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we checkpoint an container in created state ( not an ideal case) the created container also got destroyed.
Since the container fails to checkpoint because of created state, it must not delete the created container without user awareness.
With this PR, container can not checkpoint in created state.
Signed-off-by: rajasec rajasec79@gmail.com