Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.0-rc.1 #4657

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Release 1.3.0-rc.1 #4657

merged 2 commits into from
Mar 4, 2025

Conversation

rata
Copy link
Member

@rata rata commented Mar 3, 2025

[1.3.0-rc.1] - 2025-03-04

No tengo miedo al invierno, con tu recuerdo lleno de sol.

libcontainer API

Fixed

Changed

Added

@rata rata force-pushed the rata/relase-1.3.0-rc.1 branch 3 times, most recently from c8d2cc0 to 7926aca Compare March 3, 2025 16:42
@rata rata requested a review from thaJeztah March 3, 2025 16:53
@rata
Copy link
Member Author

rata commented Mar 3, 2025

I've put a date a few days in the future, but we can change it to sooner. Maintainers can edit the PR branch, in case someone wants to merge and release before ;)

@rata
Copy link
Member Author

rata commented Mar 3, 2025

All tests are green :)

@kolyshkin kolyshkin added this to the 1.3.0-rc.1 milestone Mar 3, 2025
@thaJeztah thaJeztah changed the title Relase 1.3.0-rc.1 Release 1.3.0-rc.1 Mar 3, 2025
@lifubang
Copy link
Member

lifubang commented Mar 4, 2025

Ask a question, which branch will be based on when creating the branch release-1.3? I think it' the main branch? If yes, all commits in the main branch will be included in v1.3.0-rc.1?

Or this time release only includes PRs in the milestone 1.3.0-rc.1?

@cyphar
Copy link
Member

cyphar commented Mar 4, 2025

@lifubang The branch will be forked from c39da1f, so any commits that are included there will be in the release.

@lifubang
Copy link
Member

lifubang commented Mar 4, 2025

so any commits that are included there will be in the release.

So any commits before this commit ID in the main branch will be in the release.
If I understand correctly, I think maybe we should release v1.2.6 first. Because some PRs are not mentioned in the change log and haven't been released yet. For example: #4637, #4636, etc. But perhaps it's not necessary to write everything down.

@cyphar
Copy link
Member

cyphar commented Mar 4, 2025

I'm reworking the changelog already, and those will be included. We're already a few days behind on the rc1 deadline, no need to delay it further because of the changelog.

@cyphar cyphar force-pushed the rata/relase-1.3.0-rc.1 branch from 7926aca to bc83294 Compare March 4, 2025 07:41
rata added 2 commits March 4, 2025 18:42
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
(cyphar: improve changelog)
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
@cyphar cyphar force-pushed the rata/relase-1.3.0-rc.1 branch from bc83294 to 5d6e7e1 Compare March 4, 2025 07:42
@cyphar
Copy link
Member

cyphar commented Mar 4, 2025

FWIW, I'm not sure if we want to branch release-1.3 immediately from rc1 or after rc2/GA. I guess we can play it by ear (previously we would branch off GA, but this limits what patches we can accept into main now that we're going to be more strict about rc1 and the whole release schedule).

@lifubang
Copy link
Member

lifubang commented Mar 4, 2025

I'm not sure if we want to branch release-1.3 immediately from rc1 or after rc2/GA.

I suggest to create branch release-1.3 immediately.

@cyphar
Copy link
Member

cyphar commented Mar 4, 2025

Yeah, I forgot that I even wrote that this is what we should do in RELEASES.md:

The first release candidate will be created 2 months before the planned release
date (i.e. the end of February and August, respectively), at which point the
release branch will be created and will enter a feature freeze.

😅

@cyphar cyphar merged commit 2f93d66 into opencontainers:main Mar 4, 2025
34 checks passed
@cyphar
Copy link
Member

cyphar commented Mar 4, 2025

@rata rata deleted the rata/relase-1.3.0-rc.1 branch March 4, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants