Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite Scaling CKKS Bootstrapping (#910 phase 3) #931

Open
wants to merge 39 commits into
base: dev
Choose a base branch
from
Open

Composite Scaling CKKS Bootstrapping (#910 phase 3) #931

wants to merge 39 commits into from

Conversation

fdiasmor
Copy link
Collaborator

@fdiasmor fdiasmor commented Jan 4, 2025

No description provided.

@fdiasmor
Initial commit: adding composite scaling parameters and scaling tech …
3ed5909 
…mode.
@fdiasmor
Initial commit: adding composite scaling parameters and scaling tech …
fb50d79 
…mode.
@fdiasmor
Composite prime generation and adaptive scaling factors.
d3c1a58
@fdiasmor
Propagating composite degree to mod reduce calls.
e397a73
@fdiasmor
Handling overflow for scaling factors over 64 bits on composite scali…
3bf393a 
…ng mode.
@fdiasmor
Bug fix of overflow handling for d > 2 and sc > 64.
51db3ca
@fdiasmor
Update impl of Rescale and Mod/LevelReduce methods with composite deg…
44b206b 
…ree.
@fdiasmor
Minor bug fix: else case missing.
3d2c220
@fdiasmor
Update EvalPoly functions to use composite degree.
a9c9978
@fdiasmor
Update Compress function to raise error.
c03c8f9
@fdiasmor
Update/Add new composite scaling examples.
470cd11
@fdiasmor
Recalculate sizeP and update EstimateLogP interface.
6369eaa
@fdiasmor
Updated CKKS bootstrapping for composite scaling with examples.
c29fc6b
@fdiasmor
Update error conditions.
fde39d7
@fdiasmor
Update poly evaluation example.
58881c0
@fdiasmor
Tweak error condition regarding prime moduli size.
d257f15
@fdiasmor
Update composite-prime generation function.
5d54a9f
@fdiasmor
Remove comments from prime gen function.
a5a2b9c
@fdiasmor
Update composite scaling unittests and fix unittest runtime issue.
9a7ad26
@fdiasmor fdiasmor requested a review from yspolyakov January 4, 2025 04:05
@fdiasmor fdiasmor self-assigned this Jan 4, 2025
@fdiasmor fdiasmor linked an issue Jan 4, 2025 that may be closed by this pull request
Add CKKS Composite Scaling #910
Open
@fdiasmor fdiasmor changed the title 910 Composite Scaling CKKS Bootstrapping Composite Scaling CKKS Bootstrapping (#910 phase 3) Jan 10, 2025
@fdiasmor
Copy link
Collaborator Author

fdiasmor commented Feb 14, 2025 •
edited
Loading

@dsuponitskiy Just noticed you merged #929. PR #931 still needs to be rebased with #929. Will let you know when completed and you can proceed to review this one. It shouldn't take much time. Thanks.

@fdiasmor
Copy link
Collaborator Author

@dsuponitskiy and @yspolyakov this branch is rebased with the latest composite scaling code merged into dev.

@fdiasmor fdiasmor mentioned this pull request Feb 20, 2025
Open
@dsuponitskiy
Copy link
Collaborator

I added a new commit to this branch with some correction. Please review them along with the 3 code review comments above

@fdiasmor
Copy link
Collaborator Author

fdiasmor commented Mar 5, 2025 •
edited
Loading

@dsuponitskiy The review modifications have been pushed in the latest commit.

@fdiasmor fdiasmor requested a review from dsuponitskiy March 5, 2025 03:45
@fdiasmor
Copy link
Collaborator Author

fdiasmor commented Mar 6, 2025 •
edited
Loading

I added a new commit to this branch with some correction. Please review them along with the 3 code review comments above

Done. It seems the changes from commit e54a469 introduced a bug. I have a local functional version without those changes that is working as expected.

terminate called after throwing an instance of 'lbcrypto::OpenFHEException' what(): /home/fdiasmor/openfhe-development/src/pke/lib/encoding/ckkspackedencoding.cpp:l.546:Decode(): The decryption failed because the approximation error is too high. Check the parameters. Aborted (core dumped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yspolyakov yspolyakov Awaiting requested review from yspolyakov

@dsuponitskiy dsuponitskiy Awaiting requested review from dsuponitskiy

At least 1 approving review is required to merge this pull request.

Assignees

@fdiasmor fdiasmor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CKKS Composite Scaling
4 participants
@fdiasmor @dsuponitskiy @yspolyakov @dsuponitskiy-duality