Fetch variant enterprise fees from order lineitems adjustments #11529

[abdulazizali77]

What? Why?

• Closes [Enterprise fees w/ Tax Report by Producer] Can't trace origin from enterprise fees #11529

When the order exchange is removed, the variant enterprise fees cannot be summarized. The change uses the order line item adjustment information to get the variant enterprise fee ids instead.

What should we test?

• Create an order with per item enterprise fee. Run the tax report by producer enterprise fees and note the resulting enterprise fees.
• Remove the exchange of the order cycle of that order. Rerun the tax report by producer enterprise fees and note that the resulting enterprise fees are still the same/have not disappeared.

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

The title of the pull request will be included in the release notes.

[mkllnk]

Nice work. Thank you!

[rioug]

Nice one !

[filipefurtad0]

Hey @abdulazizali77 ,

Many thanks for addressing this one!

I've reproduced the issue, before this PR:

Having the fee on the incoming section of the order cycle, adds it to the report:

Removing it from the order cycle, makes the fee untraceable and so, the report yields no results:

After staging this PR, I was expecting the fee to be seen again:

However, as seen in the pic above, this is not the case (I've double checked, that setting the fee back on the OC re-displays it in the report.)

What do you think @abdulazizali77 ? Would it be possible to have your opinion and perhaps a second look at this one?
Thank you much 🙏

[abdulazizali77]

@filipefurtad0 will look at it

[sigmundpetersen]

Hi @abdulazizali77 👋
Did you want to continue on this one?

[abdulazizali77]

Hi @abdulazizali77 👋 Did you want to continue on this one?

@sigmundpetersen While addressing the test failures, im only starting to scrutinize the logic of the By Producer report and looking at the other reports Summary and By Order both show Coordinator fees and Outgoing fees, but the By Producer only shows Incoming, why was that the case? At fitrst i thought only the Fees of Producer of the Variant/goods should be displayed but any Fee from any related Producer or Hub may be applied on incoming Variants, then why should any arbitrary fee applied in/as Outgoing and Coordinator Fee not be displayed in the By Producer report?

[sigmundpetersen]

@filipefurtad0 @RachL @openfoodfoundation/reviewers @chahmedejaz any feedback on the above ☝️

[filipefurtad0]

Hey @abdulazizali77,

why should any arbitrary fee applied in/as Outgoing and Coordinator Fee not be displayed in the By Producer report?

Only the incoming exchange section relates to the suppliers/producers (we use these terms interchangeably), so only the fees set in this section will appear at the By Producer Report.

See also the user guide for more info, I hope this helps.

It should be noted though, that currently, this report shows all fees set up on the incoming exchange, regardless of the owner of the fee (i.e., the enterprise which created it). In this aspect, Tax Report by Producer (left side, below) currently differs from the Pay your suppliers report (right side):

PS: and perhaps signalling @openfoodfoundation/train-drivers-product-owners, there are other differences between these reports, for example, setting up the producer to charge GST hides the tax parcels from the Pay your suppliers report, but leaves these visible, at the Tax Report By Producer, I wonder if we should not harmonize this behavior at some point:

Another difference is the present issue: removing the fee from the order cycle does not change the Pay your suppliers report 💪 It does so on Tax Report by Producer, as described on #11529.