-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categorise breaking-change labels in release notes #13201
Categorise breaking-change labels in release notes #13201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Just wondering about the label naming.
Much less alarming than 'breaking'.
The labels on GitHub have already been updated. [skip ci]
fc5a26b
to
da3bd4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I'll merge and we can test this with the new release.
Interesting. I didn't know that. So if we put Uncategorised at the bottom then we wouldn't need the exclude list for all the labels. I like it at the top though. We can keep it as is. 😄 |
What? Why?
https://openfoodnetwork.slack.com/archives/C01T75H6G0Z/p1741668548086439
When a release is drafted, it should be easy to see if it contains any breaking changes, so we can set the version number accordingly.
What should we test?
We could test this after merging, by assigning the labels to a recently merged PR and draft a release.
Don't forget to remove the labels after testing!
Documentation updates
https://github.com/openfoodfoundation/openfoodnetwork/wiki/Releasing