Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update line items enterprise fee instead of deleting and recreating " #13218

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Revert "Update line items enterprise fee instead of deleting and recreating " #13218

merged 1 commit into from
Mar 18, 2025

Conversation

rioug
Copy link
Collaborator

@rioug rioug commented Mar 18, 2025

Reverts #13144

@rioug rioug requested review from dacook and mkllnk and removed request for dacook March 18, 2025 22:44
dacook
dacook approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to see all your work get undone :(

mkllnk
mkllnk approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily it will be easy to bring back.

@mkllnk mkllnk merged commit a27491b into master Mar 18, 2025
65 checks passed
@mkllnk mkllnk deleted the revert-13144-13100-removed-fee-when-product-removed branch March 18, 2025 22:57
@mkllnk
Copy link
Member

mkllnk commented Mar 18, 2025

Hm, I guess that we should have tested that this solves the problem. But I just felt really confident. 😬

Testing can still be done.

@rioug rioug mentioned this pull request Mar 19, 2025
Open
@filipefurtad0 filipefurtad0 added pr-staged-fr staging.coopcircuits.fr no-staging-FR A tag which does not trigger deployments, indicating a server is being used and removed pr-staged-fr staging.coopcircuits.fr labels Mar 19, 2025
@filipefurtad0
Copy link
Contributor

Hey @rioug,

Just as a post-deploy check: I've verified in staging, that after staging current master branch, clicking Update and Recalculate Fees removes the incorrect fees from the order.

Order with incorrect enterprise fees

image

Order after staging master and clicking the Update button
image

@filipefurtad0 filipefurtad0 removed the no-staging-FR A tag which does not trigger deployments, indicating a server is being used label Mar 19, 2025
@dacook dacook added bug-s1 The bug is stopping the platform from working, and there is no workaround. Impact of lot of users. user facing changes Thes pull requests affect the user experience labels Mar 23, 2025
@rioug rioug mentioned this pull request Mar 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkllnk mkllnk mkllnk approved these changes

@dacook dacook dacook approved these changes

Assignees

@rioug rioug

Labels
bug-s1 The bug is stopping the platform from working, and there is no workaround. Impact of lot of users. user facing changes Thes pull requests affect the user experience
Projects
OFN Delivery board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rioug @mkllnk @filipefurtad0 @dacook