Fix: Admin visiting non-existent enterprise raises error #13224
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when an admin tries to edit an no-existing enterprise, a NoMethodError is raised. This commit adds a set_enterprise setter method to the enterprises controller that sets the @enterprise instance variable to have the same value as the enterprise object defined in the the edit method; this method also rescues the NotFound error in case the enterprise is not found and redirects the user to the enterprises index page with a error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Currently, when an admin tries to edit an no-existing enterprise, a
NoMethodErroris raised.This commit adds a set_enterprise setter method to the enterprise controller that sets the @enterprise instance variable to have the same value as the enterprise object defined in the edit method; this method also rescues the NotFound error in case the enterprise is not found and redirects the user to the enterprise index page with an error message.
What should we test?
/admin/enterprises/no-extisting/edityou should be redirected to the enterprises path with an error messageRelease notes
Changelog Category (reviewers may add a label for the release notes):