Spring Boot 3, Jakarta EE 9 regression #681
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for spotting and fixing this @xLitil ! We'll let the tests run, but I think we can merge this soon after |
|
It looks like we have failures on main as well, so we'll fix those there. Thanks again! |
|
Thank you @timtebeek for your quick review and merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Since PR openrewrite/rewrite-migrate-java#674, the recipe JavaxMigrationToJakarta update to Jakarta 9 and not 10
What's your motivation?
Spring Boot 3 is Jakarta 10
Anything in particular you'd like reviewers to focus on?
None
Anyone you would like to review specifically?
None
Have you considered any alternatives or workarounds?
No, it's the best option 😄
Any additional context
No
Checklist