Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes config name in yml file to new non-deprecated name #1485

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Changes config name in yml file to new non-deprecated name #1485

merged 3 commits into from
Jun 6, 2022

Conversation

boktorbb
Copy link
Contributor

@boktorbb boktorbb commented Apr 21, 2022 •
edited
Loading

Description

Updates the config name opensearch.requestHeadersWhitelist to opensearch.requestHeadersAllowlist in the opensearch_dashboards.yml file

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

Changes config name in yml file to new non-deprecated name
7f84fe6 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb requested a review from a team as a code owner April 21, 2022 15:45
Changes other reference of deprecated config name
211c4dd 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Fixes linting for branding and adds back old config name for bwc
476ef2c 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb requested review from tmarkley and kavilla April 21, 2022 20:30
@codecov-commenter
Copy link

Codecov Report

Merging #1485 (476ef2c) into main (b7ca138) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1485   +/-   ##
=======================================
  Coverage   68.09%   68.09%           
=======================================
  Files        3072     3072           
  Lines       59036    59032    -4     
  Branches     8927     8928    +1     
=======================================
  Hits        40198    40198           
+ Misses      16651    16647    -4     
  Partials     2187     2187
Impacted Files Coverage Δ
...ole/public/application/components/console_menu.tsx 58.06% <0.00%> (+6.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ca138...476ef2c. Read the comment docs.

@kavilla
Copy link
Member

kavilla commented Apr 22, 2022 •
edited
Loading

This is good for the repo but one thing to mention is I don't know what to do about the distribution. The build packages the distribution with a source controlled config file: https://github.com/opensearch-project/opensearch-build/blob/main/config/opensearch_dashboards.yml#L180. We can't just update the values in that YAML file because we have add these configs in 2.0.0 only as of right now while this config will be used by 1.x versions.

We will need to follow up with the build repo. Perhaps it is time to have an .opensearch-dashboards-tar-install.

@boktorbb
Copy link
Contributor Author

boktorbb commented Apr 22, 2022 •
edited
Loading

This is good for the repo but one thing to mention is I don't know what to do about the distribution. The build packages the distribution with a source controlled config file: https://github.com/opensearch-project/opensearch-build/blob/main/config/opensearch_dashboards.yml#L180. We can't just update the values in that YAML file because we have add these configs in 2.0.0 only as of right now while this config will be used by 1.x versions.

Could we possibly backport this and the config PR to 1.x since there are no breaking changes? It will only give a deprecation warning

@tmarkley
Copy link
Contributor

tmarkley commented Jun 6, 2022

Just to keep things linked, this is a follow-up to #1467

@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 6, 2022
Closed
@tmarkley tmarkley merged commit 7ecc8e1 into opensearch-project:main Jun 6, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 6, 2022
@github-actions
Changes config name in yml file to new non-deprecated name (#1485)
f63f395 
* Changes config name in yml file to new non-deprecated name
* Fixes linting for branding and adds back old config name for bwc

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
(cherry picked from commit 7ecc8e1)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 6, 2022
Merged
kavilla pushed a commit that referenced this pull request Jun 7, 2022
@opensearch-trigger-bot
Changes config name in yml file to new non-deprecated name (#1485) (#…
bf8e4b2 
…1676)

* Changes config name in yml file to new non-deprecated name
* Fixes linting for branding and adds back old config name for bwc

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
(cherry picked from commit 7ecc8e1)

Co-authored-by: Bishoy Boktor <boktorbb@amazon.com>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 8, 2022
@kavilla
Changes config name in yml file to new non-deprecated name (opensearc…
5480e07 
…h-project#1485)

* Changes config name in yml file to new non-deprecated name
* Fixes linting for branding and adds back old config name for bwc

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 8, 2022
@kavilla
Changes config name in yml file to new non-deprecated name (opensearc…
d00bdac 
…h-project#1485)

* Changes config name in yml file to new non-deprecated name
* Fixes linting for branding and adds back old config name for bwc

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
kavilla pushed a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Jun 16, 2022
@kavilla
Changes config name in yml file to new non-deprecated name (opensearc…
94aac78 
…h-project#1485)

* Changes config name in yml file to new non-deprecated name
* Fixes linting for branding and adds back old config name for bwc

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
@opensearch-trigger-bot
Changes config name in yml file to new non-deprecated name (opensearc…
9544361 
…h-project#1485) (opensearch-project#1676)

* Changes config name in yml file to new non-deprecated name
* Fixes linting for branding and adds back old config name for bwc

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
(cherry picked from commit 7ecc8e1)

Co-authored-by: Bishoy Boktor <boktorbb@amazon.com>
cliu123 pushed a commit to cliu123/OpenSearch-Dashboards that referenced this pull request Jun 30, 2022
@opensearch-trigger-bot
Changes config name in yml file to new non-deprecated name (opensearc…
119ad78 
…h-project#1485) (opensearch-project#1676)

* Changes config name in yml file to new non-deprecated name
* Fixes linting for branding and adds back old config name for bwc

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
(cherry picked from commit 7ecc8e1)

Co-authored-by: Bishoy Boktor <boktorbb@amazon.com>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Aug 10, 2022
Changes config name in yml file to new non-deprecated name (opensearc…
b0ea3bb 
…h-project#1485)

* Changes config name in yml file to new non-deprecated name
* Fixes linting for branding and adds back old config name for bwc

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmarkley tmarkley tmarkley approved these changes

@kavilla kavilla kavilla approved these changes

Assignees
No one assigned
Labels
backport 2.x deprecation needs-documentation v2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boktorbb @codecov-commenter @kavilla @tmarkley