-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes config name in yml file to new non-deprecated name #1485
Conversation
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1485 +/- ##
=======================================
Coverage 68.09% 68.09%
=======================================
Files 3072 3072
Lines 59036 59032 -4
Branches 8927 8928 +1
=======================================
Hits 40198 40198
+ Misses 16651 16647 -4
Partials 2187 2187
Continue to review full report at Codecov.
|
This is good for the repo but one thing to mention is I don't know what to do about the distribution. The build packages the distribution with a source controlled config file: https://github.com/opensearch-project/opensearch-build/blob/main/config/opensearch_dashboards.yml#L180. We can't just update the values in that YAML file because we have add these configs in 2.0.0 only as of right now while this config will be used by We will need to follow up with the build repo. Perhaps it is time to have an |
Could we possibly backport this and the config PR to |
Just to keep things linked, this is a follow-up to #1467 |
* Changes config name in yml file to new non-deprecated name * Fixes linting for branding and adds back old config name for bwc Signed-off-by: Bishoy Boktor <boktorbb@amazon.com> (cherry picked from commit 7ecc8e1)
…h-project#1485) * Changes config name in yml file to new non-deprecated name * Fixes linting for branding and adds back old config name for bwc Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
…h-project#1485) * Changes config name in yml file to new non-deprecated name * Fixes linting for branding and adds back old config name for bwc Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
…h-project#1485) * Changes config name in yml file to new non-deprecated name * Fixes linting for branding and adds back old config name for bwc Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
…h-project#1485) (opensearch-project#1676) * Changes config name in yml file to new non-deprecated name * Fixes linting for branding and adds back old config name for bwc Signed-off-by: Bishoy Boktor <boktorbb@amazon.com> (cherry picked from commit 7ecc8e1) Co-authored-by: Bishoy Boktor <boktorbb@amazon.com>
…h-project#1485) (opensearch-project#1676) * Changes config name in yml file to new non-deprecated name * Fixes linting for branding and adds back old config name for bwc Signed-off-by: Bishoy Boktor <boktorbb@amazon.com> (cherry picked from commit 7ecc8e1) Co-authored-by: Bishoy Boktor <boktorbb@amazon.com>
…h-project#1485) * Changes config name in yml file to new non-deprecated name * Fixes linting for branding and adds back old config name for bwc Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Description
Updates the config name
opensearch.requestHeadersWhitelist
toopensearch.requestHeadersAllowlist
in theopensearch_dashboards.yml
fileIssues Resolved
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr