Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [CCI] Replace jquery usage in console plugin with native methods #3858

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ffe4556 from #3733.

* Remove jquery import and unused mock test
* Removed jquery imports and replaced jquery functions and methods to native js in console plugin tests
* Removed jquery imports and replaced jquery functions to native js in console plugin
* Adding a changelog entry
* Accept changes from new mappings
* Update to template string

Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>

---------

Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit ffe4556)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner April 17, 2023 17:57
Signed-off-by: Josh Romero <rmerqg@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Merging #3858 (b6dc5c0) into 2.x (da6c2fa) will decrease coverage by 0.01%.
The diff coverage is 53.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3858      +/-   ##
==========================================
- Coverage   66.43%   66.43%   -0.01%     
==========================================
  Files        3209     3208       -1     
  Lines       61710    61713       +3     
  Branches     9532     9532              
==========================================
- Hits        40999    40998       -1     
- Misses      18426    18429       +3     
- Partials     2285     2286       +1     
Flag Coverage Δ
Linux 66.37% <46.66%> (-0.01%) ⬇️
Windows 66.38% <46.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/models/legacy_core_editor/legacy_core_editor.ts 56.94% <41.66%> (-0.20%) ⬇️
src/plugins/console/public/lib/osd/osd.js 74.54% <100.00%> (+4.17%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@manasvinibs manasvinibs merged commit b7af56f into 2.x Apr 17, 2023
@github-actions github-actions bot deleted the backport/backport-3733-to-2.x branch April 17, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants