Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Revert "[CCI] Replace jquery usage in console plugin with native methods" #3936

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[Backport 2.x] Revert "[CCI] Replace jquery usage in console plugin with native methods" #3936

merged 1 commit into from
Apr 25, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b97a4b5 from #3929.

@github-actions
Revert "[CCI] Replace jquery usage in console plugin with native meth…
cf7e9e3 
…ods (#3733)" (#3929)

This reverts commit ffe4556.

(cherry picked from commit b97a4b5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@ashwin-pc ashwin-pc added the autocut Skip the changelog verification check on backports label Apr 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3936 (cf7e9e3) into 2.x (d58c9ce) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3936      +/-   ##
==========================================
- Coverage   66.44%   66.39%   -0.05%     
==========================================
  Files        3227     3228       +1     
  Lines       62028    62025       -3     
  Branches     9591     9591              
==========================================
- Hits        41215    41182      -33     
- Misses      18513    18539      +26     
- Partials     2300     2304       +4
Flag Coverage Δ
Linux ?
Windows 66.39% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/models/legacy_core_editor/legacy_core_editor.ts 57.14% <37.50%> (+0.19%) ⬆️
src/plugins/console/public/lib/osd/osd.js 70.37% <50.00%> (-4.18%) ⬇️
...ion/models/sense_editor/sense_editor.test.mocks.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr merged commit 7416cb7 into 2.x Apr 25, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-3929-to-2.x branch April 25, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@kavilla kavilla kavilla approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @joshuarrrr @kavilla @ashwin-pc