[CCI] Add bluebird replaces for src/plugins/vis_type_timeline

[Nicksqain]

Description

Issues Resolved

• closes Eliminate Bluebird in favor of native async functionality #3662

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Merging #4025 (87d9a82) into main (574f119) will decrease coverage by 0.11%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             main    #4025      +/-   ##
==========================================
- Coverage   66.46%   66.35%   -0.11%     
==========================================
  Files        3229     3229              
  Lines       62091    62137      +46     
  Branches     9607     9619      +12     
==========================================
- Hits        41269    41234      -35     
- Misses      18511    18581      +70     
- Partials     2311     2322      +11     

Flag	Coverage Δ
Linux	66.30% <76.47%> (-0.11%)	⬇️
Windows	66.30% <76.47%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/osd-dev-utils/src/proc_runner/proc.ts	6.52% <0.00%> (ø)
packages/osd-pm/src/utils/fs.ts	13.04% <ø> (-20.29%)	⬇️
src/core/public/core_app/status/status_app.tsx	0.00% <0.00%> (ø)
src/core/public/doc_links/doc_links_service.ts	100.00% <ø> (ø)
src/core/server/bootstrap.ts	0.00% <0.00%> (ø)
src/core/server/plugins/types.ts	100.00% <ø> (ø)
src/core/server/status/status_service.ts	78.94% <ø> (ø)
...components/create_form/create_data_source_form.tsx	74.00% <ø> (ø)
...tion/server/collectors/application_usage/schema.ts	100.00% <ø> (ø)
..._collection/server/collectors/management/schema.ts	100.00% <ø> (ø)
... and 24 more

... and 23 files with indirect coverage changes

[ananzh]

Does chainRunner.processRequest(request.body) returns returns an array of promises? or it returns an iterable (like a Set) of promises, so you convert it to an array before passing it to Promise.all?

From chainRunnerFn def, I see the return is

return {
    processRequest: processRequest,
    getStats: function () {
      return stats;
    },
  };

where processRequest is defined as

function processRequest(request) {
    if (!request) throw new Error('Empty request body');

    validateTime(request.time, tlConfig);

    tlConfig.time = request.time;
    tlConfig.time.to = moment(request.time.to).valueOf();
    tlConfig.time.from = moment(request.time.from).valueOf();
    tlConfig.time.interval = calculateInterval(
      tlConfig.time.from,
      tlConfig.time.to,
      tlConfig.settings['timeline:target_buckets'] || 200,
      tlConfig.time.interval,
      tlConfig.settings['timeline:min_interval'] || '1ms'
    );

    tlConfig.setTargetSeries();

    stats.invokeTime = new Date().getTime();
    stats.queryCount = 0;
    queryCache = {};

    // This is setting the "global" sheet, required for resolving references
    sheet = parseSheet(request.sheet);
    return preProcessSheet(sheet).then(function () {
      return _.map(sheet, function (chainList, i) {
        return resolveChainList(chainList)
          .then(function (seriesList) {
            stats.sheetTime = new Date().getTime();
            return seriesList;
          })
          .catch(function (e) {
            throwWithCell(i, e);
          });
      });
    });
  }

The _.map function from lodash is being used here.resolveChainList(chainList) returns a Promise. _.map returns an array. So it seems to me the return type is array of Promise. Therefore, we could do

const sheet = await Promise.all(chainRunner.processRequest(request.body));

?

Could you help me to double check and verify? Could set some console logs to verify the type of promises chainRunner returns.

Since this is in server, you could add launch.json in .vscode then add a break point when you run a timeline func

{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "pwa-node",
            "request": "attach",
            "name": "back",
            "port": 9229
        }
    ]
}

[ananzh]

Overall nice and clean change! Thank you so much. I have two suggestions here:

• Help to verify the return type const promises = chainRunner.processRequest(request.body); Pls see my comment.
• Add CHANGELOG.

[Nicksqain]

@ananzh
Thanks for the reply!
Should the .vscode folder be in the server folder? Or in the root of the project? I can't get the debugger to run.
How can I run this function if it is tied to an api endpoint?

[AMoo-Miki]

Suggested change

	- Add bluebird replaces for vis_type_timeline plugin ([#4025](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4025))
	- Replace the use of `bluebird` in the `vis_type_timeline` plugin ([#4025](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4025))

[ananzh]

@Nicksqain

[ananzh]

@Nicksqain I think const promises = chainRunner.processRequest(request.body); should return <Promise<Array<Promise<some data type>>>. Therefore, const sheet = await Promise.all(chainRunner.processRequest(request.body)); is more appropriate here. Feel free to verify and pls resolve the CHANGELOG conflict and rebase to let this PR tested with our latest changes.

[Nicksqain]

@Nicksqain I think const promises = chainRunner.processRequest(request.body); should return <Promise<Array<Promise<some data type>>>. Therefore, const sheet = await Promise.all(chainRunner.processRequest(request.body)); is more appropriate here. Feel free to verify and pls resolve the CHANGELOG conflict and rebase to let this PR tested with our latest changes.

@ananzh
At first I thought so too, but because I didn't put in the changes I saw that there was an error, checked the type and it really didn't match the iterable type

[Nicksqain]

@ananzh My git is broken, I'm sorry. how do I roll back my rebase?

[ananzh]

@Nicksqain A simple way is to pull the latest main, then create a new branch and cherry-pick the commit here. Then force push.

[ananzh]

const sheet = await Promise.all(chainRunner.processRequest(request.body));

@Nicksqain I don't what causes the error in your screenshot, but I tried to use const sheet = await Promise.all(chainRunner.processRequest(request.body)); and can't reproduce your error. Here is the commit:
main...ananzh:OpenSearch-Dashboards:timeline-bluebird

Here is the function test group 1 result:
https://github.com/ananzh/OpenSearch-Dashboards/actions/runs/5148602476/jobs/9270514321

 └-: timeline app
         └-> "before all" hook in "timeline app"
         └-> "before all" hook in "timeline app"
         └-: expression typeahead
           └-> "before all" hook for "should display function suggestions filtered by function name"
           └-> "before all" hook for "should display function suggestions filtered by function name"
             │ proc [opensearch-dashboards]   log   [20:06:50.309] [info][savedobjects-service] Creating index .kibana_2.
             │ proc [opensearch-dashboards]   log   [20:06:50.369] [info][savedobjects-service] Reindexing .kibana to .kibana_1
             │ proc [opensearch-dashboards]   log   [20:06:50.724] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
             │ proc [opensearch-dashboards]   log   [20:06:50.728] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
             │ proc [opensearch-dashboards]   log   [20:06:50.743] [info][savedobjects-service] Finished in 435ms.
             │ERROR browser[SEVERE] http://localhost:6610/9007199254740991/bundles/core/core.entry.js 20496:18 TypeError: Failed to fetch
             │          at Fetch.fetchResponse (http://localhost:6610/9007199254740991/bundles/core/core.entry.js:21071:13)
             │          at async interceptResponse (http://localhost:6610/9007199254740991/bundles/core/core.entry.js:21574:10)
             │          at async http://localhost:6610/9007199254740991/bundles/core/core.entry.js:20982:39
           └-> should display function suggestions filtered by function name
             └-> "before each" hook: global before each for "should display function suggestions filtered by function name"
             └- ✓ pass  (468ms) "timeline app expression typeahead should display function suggestions filtered by function name"
           └-> should show argument suggestions when function suggestion is selected
             └-> "before each" hook: global before each for "should show argument suggestions when function suggestion is selected"
             └- ✓ pass  (1.6s) "timeline app expression typeahead should show argument suggestions when function suggestion is selected"
           └-> should show argument value suggestions when argument is selected
             └-> "before each" hook: global before each for "should show argument value suggestions when argument is selected"
             └- ✓ pass  (2.7s) "timeline app expression typeahead should show argument value suggestions when argument is selected"
           └-: dynamic suggestions for argument values
             └-: .opensearch()
               └-> should show index pattern suggestions for index argument
               └-> should show field suggestions for timefield argument when index pattern set
               └-> should show field suggestions for split argument when index pattern set
               └-> should show field suggestions for metric argument when index pattern set
           └-> "after all" hook for "should show argument value suggestions when argument is selected"
         └-> "after all" hook in "timeline app"
     │

Note: I removed the bootstrap for windows. so windows failure is fine. See linux passed all ftr tests.

[ananzh]

@Nicksqain Due to an extended period without updates, we're going to close this issue for now. We appreciate your contribution and understand that priorities and availability can change. Please feel free to reopen this issue when you have the opportunity to revisit it. Thank you for your understanding.