Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [MD] Update authentication helper text in create data source flow #4186

Merged
merged 2 commits into from
May 31, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 821ad73 from #4179.

resolves #4173

Signed-off-by: Su <szhongna@amazon.com>
(cherry picked from commit 821ad73)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kavilla kavilla added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #4186 (ce003cc) into 2.x (c453ba2) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head ce003cc differs from pull request most recent head 20735fd. Consider uploading reports for the commit 20735fd to get more accurate results

@@            Coverage Diff             @@
##              2.x    #4186      +/-   ##
==========================================
- Coverage   66.35%   66.30%   -0.06%     
==========================================
  Files        3229     3229              
  Lines       62091    62091              
  Branches     9611     9611              
==========================================
- Hits        41203    41167      -36     
- Misses      18569    18599      +30     
- Partials     2319     2325       +6     
Flag Coverage Δ
Linux ?
Windows 66.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/create_form/create_data_source_form.tsx 74.00% <ø> (ø)

... and 7 files with indirect coverage changes

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
@kavilla
Copy link
Member

kavilla commented May 31, 2023

Previous tests succeeded besides cypress tests. Now that cypress test succeeded with cypress tests updates will merge.

@kavilla kavilla merged commit a7cb787 into 2.x May 31, 2023
@github-actions github-actions bot deleted the backport/backport-4179-to-2.x branch May 31, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants