[Backport 2.7] Fix Node.js download link (#4556) #4594
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
requested review from
ananzh,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu and
manasvinibs
as code owners
https://mirrors.nodejs.org/ is no longer available which prevents the ability from release builds being made. Restoring back the original link. Follow-up should be considered about a caching mechanism and param to the CLI to utilize another link or path. Signed-off-by: Miki <miki@amazon.com>
kavilla
force-pushed
the
kavilla/2.7/nodelink
branch
from
1268126 to
dc4c853
Compare
kavilla
added
the
Skip-Changelog
Codecov Report
@@ Coverage Diff @@
## 2.7 #4594 +/- ##
=======================================
Coverage 66.44% 66.44%
=======================================
Files 3229 3229
Lines 62045 62045
Branches 9597 9597
=======================================
+ Hits 41226 41228 +2
+ Misses 18517 18516 -1
+ Partials 2302 2301 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ashwin-pc
reviewed
Jul 20, 2023
|
Also cypress tests are failing here |
|
@kavilla Do we need to backport to 2.7? If so, do you mind looking at the test failures? |
joshuarrrr
added
not in release
|
We have passed the need for this with 2.8 and 2.9 releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of d746595 from #4556