[Multiple Datasource] Export DataSourcePluginRequestContext at top level for plugins to use #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu Yu <nluyu@amazon.com>
BionIT
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe and
ruanyl
as code owners
Signed-off-by: Lu Yu <nluyu@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6108 +/- ##
==========================================
+ Coverage 67.13% 67.15% +0.01%
==========================================
Files 3324 3324
Lines 64318 64318
Branches 10344 10344
==========================================
+ Hits 43178 43190 +12
+ Misses 18617 18605 -12
Partials 2523 2523
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xinruiba
approved these changes
Mar 11, 2024
BionIT
added
v2.13.0
backport 2.x
multiple datasource
ZilongX
approved these changes
Mar 11, 2024
| @@ -20,4 +20,8 @@ export function plugin(initializerContext: PluginInitializerContext) { | |||
| return new DataSourcePlugin(initializerContext); | |||
| } | |||
|
|
|||
| export { DataSourcePluginSetup, DataSourcePluginStart } from './types'; | |||
| export { | |||
There was a problem hiding this comment.
Is this the only location need to add requestcontext? Thanks
Flyingliuhub
approved these changes
Mar 11, 2024
28 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
…vel for plugins to use (#6108) * export context as top level Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit ead2947) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BionIT
pushed a commit
that referenced
this pull request
Mar 11, 2024
…vel for plugins to use (#6108) (#6111) * export context as top level Signed-off-by: Lu Yu <nluyu@amazon.com> * add changelog Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit ead2947) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change export DataSourcePluginRequestContext at top level for external plugins to consume
Issues Resolved
Fixes #6045
Screenshot
type.mp4
Testing the changes
The following were performed in the recording:
Check List
yarn test:jestyarn test:jest_integration