[Discover-next] add data source selector #7128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Onboards data source selector from Discover next. The index patterns populated are based on the current data source. If the default cluster is not the local cluster then Discover pretty much breaks because it will default assume the data source by the current context which is currently only the local cluster. Another way to say it: when the default data source is not the local cluster, Discover is still only displaying the index patterns in the local cluster. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
requested review from
ananzh,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7128 +/- ##
==========================================
- Coverage 67.45% 67.44% -0.01%
==========================================
Files 3448 3448
Lines 67964 67966 +2
Branches 11057 11057
==========================================
- Hits 45845 45843 -2
- Misses 19446 19449 +3
- Partials 2673 2674 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
reviewed
Jun 30, 2024
| @@ -104,6 +107,16 @@ export const TopNav = ({ opts, showSaveQuery }: TopNavProps) => { | |||
| onQuerySubmit={opts.onQuerySubmit} | |||
| savedQueryId={state.savedQuery} | |||
| onSavedQueryIdChange={updateSavedQueryId} | |||
| showDataSourceMenu={dataSource?.dataSourceEnabled} | |||
There was a problem hiding this comment.
Im a lil confused how this PR works. If you are using the local cluster, whats the purpose of this menu?
ashwin-pc
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Onboards data source selector from Discover next.
The index patterns populated are based on the current data source. If the default cluster is not the local cluster then Discover pretty much breaks because it will default assume the data source by the current context which is currently only the local cluster.
Another way to say it:
when the default data source is not the local cluster, Discover is still only displaying the index patterns in the local cluster.
Issues Resolved
related: #7129
Changelog
Check List
yarn test:jestyarn test:jest_integration