[Workspace] refactor: update workspace collaborator table UI #8543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
opensearch-changeset-bot bot
added a commit
to raintygao/OpenSearch-Dashboards
that referenced
this pull request
Oct 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8543 +/- ##
=======================================
Coverage 60.95% 60.95%
=======================================
Files 3776 3777 +1
Lines 89638 89641 +3
Branches 14045 14046 +1
=======================================
+ Hits 54639 54645 +6
+ Misses 31587 31583 -4
- Partials 3412 3413 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
previously approved these changes
Oct 10, 2024
Hailong-am
reviewed
Oct 10, 2024
Comment on lines
101
to
108
| actions={ | ||
| <AddCollaboratorButton | ||
| displayedTypes={displayedCollaboratorTypes} | ||
| permissionSettings={permissionSettings} | ||
| handleSubmitPermissionSettings={handleSubmitPermissionSettings} | ||
| /> | ||
| } | ||
| /> |
There was a problem hiding this comment.
Learn more in documentation link is missing?
There was a problem hiding this comment.
The link is still missing, so we can ignore it for now.
Comment on lines
151
to
154
| if (result?.success) { | ||
| setPermissionSettings(settings); | ||
| } | ||
| }; |
There was a problem hiding this comment.
nit: could simplified to check result only, as success is always true based on its definition
Promise<{ result: boolean; success: true } | undefined>;
SuZhou-Joe
reviewed
Oct 11, 2024
src/plugins/workspace/public/components/workspace_form/workspace_collaborator_table.tsx
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Oct 11, 2024
src/plugins/workspace/public/components/workspace_form/use_workspace_form.ts
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Oct 11, 2024
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
raintygao
force-pushed
the
collaborator
branch
from
dc8b857 to
cefb90b
Compare
SuZhou-Joe
approved these changes
Oct 11, 2024
Hailong-am
approved these changes
Oct 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
* update workspace collaborator table UI Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #8543 created/updated * test: add tests Signed-off-by: tygao <tygao@amazon.com> * update Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 794757d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 11, 2024
…8559) * update workspace collaborator table UI * Changeset file for PR #8543 created/updated * test: add tests * update --------- (cherry picked from commit 794757d) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…rch-project#8543) * update workspace collaborator table UI Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#8543 created/updated * test: add tests Signed-off-by: tygao <tygao@amazon.com> * update Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor: update workspace collaborator table UI
Screenshot
Testing the changes
Go to workspace settings page and see the changes.
Changelog
Check List
yarn test:jestyarn test:jest_integration