Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workspace] Fix : should not show summary if there is no response #9480

Merged
merged 3 commits into from
Mar 4, 2025
Merged

[workspace] Fix : should not show summary if there is no response #9480

merged 3 commits into from
Mar 4, 2025

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Mar 4, 2025 •
edited
Loading

Description

This PR fixes a bug where the summary is displayed even when there is no response.

Issues Resolved

Screenshot

2025-03-04.10.56.48.-.Compressed.with.FlexClip.mp4

Changelog

  • fix: should not show summary if there is no response

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Qxisylolo
shouldnot show summary if no response
a2fba22 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo Qxisylolo marked this pull request as ready for review March 4, 2025 03:01
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.74%. Comparing base (5f9e470) to head (14a65bf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/query_assist/components/query_assist_summary.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9480      +/-   ##
==========================================
- Coverage   61.74%   61.74%   -0.01%     
==========================================
  Files        3816     3816              
  Lines       91886    91887       +1     
  Branches    14564    14565       +1     
==========================================
  Hits        56734    56734              
  Misses      31494    31494              
- Partials     3658     3659       +1
Flag Coverage Δ
Linux_1 28.98% <ø> (ø)
Linux_2 56.41% <ø> (ø)
Linux_3 39.26% <ø> (ø)
Linux_4 28.87% <50.00%> (-0.01%) ⬇️
Windows_1 29.00% <ø> (ø)
Windows_2 56.36% <ø> (ø)
Windows_3 39.27% <ø> (ø)
Windows_4 28.87% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qxisylolo
combination
14a65bf 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Hailong-am Hailong-am merged commit 1d74fd1 into opensearch-project:main Mar 4, 2025
73 of 75 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 4, 2025
@github-actions @opensearch-changeset-bot
[workspace] Fix : should not show summary if there is no response (#9480
20698ed 
)

* shouldnot show summary if no response

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Changeset file for PR #9480 created/updated

* combination

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

---------

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1d74fd1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@Hailong-am Hailong-am Hailong-am approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

@angle943 angle943 Awaiting requested review from angle943 angle943 is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qxisylolo @ruanyl @Hailong-am