Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] fix delete all old workspaces #9555

Merged

Conversation

angle943
Copy link
Collaborator

Description

  • when we have multiple workspaces in our test to the point where we have a paginated result of the workspaces, the tests begin failing due to the custom command deleteAllOldWorkspaces not knowing how to deal with the paginated links. This change fixes it so that we don't click those

Testing the changes

  • verified that it works by manually creating a lot of workspaces and having the tests still passing

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Justin Kim <jungkm@amazon.com>
@angle943 angle943 added discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative and removed all-star-contributor labels Mar 17, 2025
@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Mar 17, 2025
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.83%. Comparing base (29f05d7) to head (2b69e52).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9555      +/-   ##
==========================================
+ Coverage   61.82%   61.83%   +0.01%     
==========================================
  Files        3825     3825              
  Lines       92040    92040              
  Branches    14598    14598              
==========================================
+ Hits        56902    56916      +14     
+ Misses      31464    31451      -13     
+ Partials     3674     3673       -1     
Flag Coverage Δ
Linux_1 28.94% <ø> (ø)
Linux_2 56.38% <ø> (ø)
Linux_3 39.42% <ø> (?)
Linux_4 28.85% <ø> (ø)
Windows_1 28.98% <ø> (+0.01%) ⬆️
Windows_2 56.33% <ø> (ø)
Windows_3 39.43% <ø> (+<0.01%) ⬆️
Windows_4 28.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@angle943 angle943 merged commit 0671c5a into opensearch-project:main Mar 17, 2025
77 of 80 checks passed
@angle943 angle943 deleted the fix-delete-all-old-workspaces branch March 17, 2025 23:05
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 17, 2025
Signed-off-by: Justin Kim <jungkm@amazon.com>
(cherry picked from commit 0671c5a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants