Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover]fix: should clear previous query if input invalid questions #9605

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Mar 26, 2025

Description

This pr retains previous query if input invalid questions and adds callout

Screenshot

2025-03-28.16.45.35.mov

Testing the changes

Changelog

  • fix: should clear previous query if input invalid questions

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo Qxisylolo marked this pull request as ready for review March 26, 2025 03:31
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.78%. Comparing base (4315eba) to head (5eef60f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9605      +/-   ##
==========================================
- Coverage   61.81%   61.78%   -0.03%     
==========================================
  Files        3825     3807      -18     
  Lines       92069    91934     -135     
  Branches    14605    14597       -8     
==========================================
- Hits        56913    56803     -110     
+ Misses      31476    31452      -24     
+ Partials     3680     3679       -1     
Flag Coverage Δ
Linux_1 28.84% <ø> (-0.10%) ⬇️
Linux_2 56.30% <ø> (ø)
Linux_3 39.33% <ø> (-0.09%) ⬇️
Linux_4 28.76% <100.00%> (-0.13%) ⬇️
Windows_1 28.86% <ø> (-0.10%) ⬇️
Windows_2 56.26% <ø> (ø)
Windows_3 39.33% <ø> (-0.10%) ⬇️
Windows_4 28.76% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SuZhou-Joe
SuZhou-Joe previously approved these changes Mar 26, 2025
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants