Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pull-based Ingestion] Add error handling strategy to pull-based ingestion #17427

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

varunbharadwaj
Copy link
Contributor

@varunbharadwaj varunbharadwaj commented Feb 22, 2025

Description

This PR is a follow up for pull-based-ingestion to add error handling support. We introduce the following two strategies:

  1. DROP: Drop errors and proceed with remaining updates in the ingestion source.
  2. BLOCK: Block on any errors, preventing further writes.

This PR adds the drop/block support along with required interfaces. A follow up PR will add metric emission and record the errors.

When using Block strategy, we need a way to allow users to resume ingestion. Ingestion management APIs will be added to allow users more flexibility as part of #17442

Related Issues

Resolves #17085

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing labels Feb 22, 2025
Copy link
Contributor

❌ Gradle check result for dc4722f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@varunbharadwaj varunbharadwaj changed the title Add error handling strategy to pull-based ingestion [Pull-based Ingestion] Add error handling strategy to pull-based ingestion Feb 22, 2025
@varunbharadwaj varunbharadwaj marked this pull request as ready for review February 24, 2025 21:49
Copy link
Contributor

❌ Gradle check result for d0168ee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1b61879: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7eee397: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 474008b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 6dc359a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 441b463: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @varunbharadwaj. Can you add a changelog entry in CHANGELOG-3.0.md and also rebase this with the latest on main?

Copy link
Contributor

github-actions bot commented Mar 4, 2025

✅ Gradle check result for 1904e14: SUCCESS

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 88.52459% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.51%. Comparing base (218f353) to head (a431b14).

Files with missing lines Patch % Lines
.../indices/pollingingest/IngestionErrorStrategy.java 66.66% 3 Missing and 1 partial ⚠️
...pensearch/plugin/kafka/KafkaPartitionConsumer.java 0.00% 1 Missing ⚠️
...g/opensearch/cluster/metadata/IngestionSource.java 83.33% 0 Missing and 1 partial ⚠️
...ndices/pollingingest/MessageProcessorRunnable.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17427      +/-   ##
============================================
+ Coverage     72.46%   72.51%   +0.04%     
- Complexity    65707    65739      +32     
============================================
  Files          5307     5310       +3     
  Lines        304774   304825      +51     
  Branches      44193    44196       +3     
============================================
+ Hits         220850   221033     +183     
+ Misses        65898    65766     -132     
  Partials      18026    18026              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
@varunbharadwaj
Copy link
Contributor Author

Looks good @varunbharadwaj. Can you add a changelog entry in CHANGELOG-3.0.md and also rebase this with the latest on main?

Sure, updated. Please take a look.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

✅ Gradle check result for a431b14: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Error handling for pull-based ingestion
3 participants