Issue #671 fix trigger name validation

[wang-chenxi]

Description

Worked on [ trigger name validation issue](url)

Issues Resolved

• update the existing trigger name validation helper to make it compile with the current trigger and monitor setup
• apply the new trigger to all types of monitor creation, and update the callback of the usage
• address unit tests

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.78%. Comparing base (598b086) to head (7033e61).
Report is 42 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   49.84%   49.78%   -0.07%     
==========================================
  Files         232      232              
  Lines        6556     6562       +6     
  Branches      938      939       +1     
==========================================
- Hits         3268     3267       -1     
- Misses       3285     3292       +7     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wang-chenxi]

Per discussion with Thomas:

1 Backport failing - this issue is able to be ignored

2 E2E tests fails

Checked the failing tests, seems are bugs which have been pointed out in this issue

1. Bucket-level monitors failing by visual editor:
   

• correlated issue mentioned in 415:
  

2. CompositeLevelMonitor failed
   
   this one has not been pointed out in issue 415, however, i am not sure why it is never created.

3 codecov issue

I have no idea what is it

[wang-chenxi]

• fixed all tests failures and the local cypress tests passed as expected:

alerting-dashboards-plugin ricl$ yarn run cypress run
yarn run v1.22.19
$ /Users/ricl/Chenxi/OpenSearch-Dashboards/plugins/alerting-dashboards-plugin/node_modules/.bin/cypress run

====================================================================================================

(Run Starting)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Cypress: 6.9.1 │
│ Browser: Electron 87 (headless) │
│ Specs: 9 found (acknowledge_alerts_modal_spec.js, alert_spec.js, alerts_dashboard_flyout_ │
│ spec.js, bucket_level_monitor_spec.js, cluster_metrics_monitor_spec.js, composite_ │
│ level_monitor_spec.js, document_level_monitor_spec.js, monitors_dashboard_spec.js, │
│ query_lev...) │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

────────────────────────────────────────────────────────────────────────────────────────────────────

Running: acknowledge_alerts_modal_spec.js (1 of 9)
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating

AcknowledgeAlertsModal
✓ Acknowledge button disabled when more than 1 trigger selected (71495ms)
✓ Bucket-level monitor modal test (12660ms)
✓ Query-level monitor modal test (11459ms)

3 passing (2m)

(Results)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 3 │
│ Passing: 3 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: true │
│ Duration: 1 minute, 44 seconds │
│ Spec Ran: acknowledge_alerts_modal_spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

(Video)

• Started processing: Compressing to 32 CRF
• Finished processing: /Users/ricl/Chenxi/OpenSearch-Dashboards/plugins/alerting-d (8 seconds)
  ashboards-plugin/cypress/videos/acknowledge_alerts_modal_sp
  ec.js.mp4

────────────────────────────────────────────────────────────────────────────────────────────────────

Running: alert_spec.js (2 of 9)

Alerts
can be in 'Active' state
✓ after the monitor starts running (70848ms)
can be in 'Acknowledged' state
✓ by clicking the button in Dashboard (4034ms)
can be in 'Completed' state
✓ when the trigger condition is not met after met once (67571ms)
can be in 'Error' state
✓ by using a wrong destination (3453ms)
can be in 'Deleted' state
✓ by deleting the monitor (4995ms)

5 passing (3m)

(Results)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 5 │
│ Passing: 5 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: true │
│ Duration: 2 minutes, 32 seconds │
│ Spec Ran: alert_spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

(Video)

• Started processing: Compressing to 32 CRF
  Compression progress: 95%
• Finished processing: /Users/ricl/Chenxi/OpenSearch-Dashboards/plugins/alerting-d (11 seconds)
  ashboards-plugin/cypress/videos/alert_spec.js.mp4

────────────────────────────────────────────────────────────────────────────────────────────────────

Running: alerts_dashboard_flyout_spec.js (3 of 9)

Alerts by trigger flyout
✓ Bucket-level monitor flyout test (79639ms)
✓ Query-level monitor flyout test (8468ms)

2 passing (2m)

(Results)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 2 │
│ Passing: 2 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: true │
│ Duration: 1 minute, 33 seconds │
│ Spec Ran: alerts_dashboard_flyout_spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

(Video)

• Started processing: Compressing to 32 CRF
• Finished processing: /Users/ricl/Chenxi/OpenSearch-Dashboards/plugins/alerting-d (7 seconds)
  ashboards-plugin/cypress/videos/alerts_dashboard_flyout_spe
  c.js.mp4

────────────────────────────────────────────────────────────────────────────────────────────────────

Running: bucket_level_monitor_spec.js (4 of 9)

Bucket-Level Monitors
can be created
✓ by extraction query (31371ms)
✓ by visual editor (30271ms)
can be updated
when defined by visual editor
✓ by adding trigger (15839ms)
✓ to have multiple indices (10322ms)

4 passing (2m)

(Results)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 4 │
│ Passing: 4 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: true │
│ Duration: 1 minute, 32 seconds │
│ Spec Ran: bucket_level_monitor_spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

(Video)

• Started processing: Compressing to 32 CRF
• Finished processing: /Users/ricl/Chenxi/OpenSearch-Dashboards/plugins/alerting-d (8 seconds)
  ashboards-plugin/cypress/videos/bucket_level_monitor_spec.j
  s.mp4

────────────────────────────────────────────────────────────────────────────────────────────────────

Running: cluster_metrics_monitor_spec.js (5 of 9)

ClusterMetricsMonitor
can be created
✓ for the Cluster Health API (17160ms)
✓ for the Nodes Stats API (9954ms)
displays Path parameters field appropriately
✓ for the CAT Snapshots API (6055ms)
clearTriggersModal renders and behaves as expected
✓ when no triggers exist (4500ms)
✓ when triggers exist (10058ms)
can update
Cluster Health API monitor
✓ with a new trigger (8224ms)

6 passing (60s)

(Results)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 6 │
│ Passing: 6 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: true │
│ Duration: 59 seconds │
│ Spec Ran: cluster_metrics_monitor_spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

(Video)

• Started processing: Compressing to 32 CRF
• Finished processing: /Users/ricl/Chenxi/OpenSearch-Dashboards/plugins/alerting-d (5 seconds)
  ashboards-plugin/cypress/videos/cluster_metrics_monitor_spe
  c.js.mp4

────────────────────────────────────────────────────────────────────────────────────────────────────

Running: composite_level_monitor_spec.js (6 of 9)

CompositeLevelMonitor
can be created
✓ by visual editor (16372ms)
can be edited
✓ by visual editor (9044ms)

2 passing (29s)

(Results)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 2 │
│ Passing: 2 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: true │
│ Duration: 29 seconds │
│ Spec Ran: composite_level_monitor_spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

(Video)

• Started processing: Compressing to 32 CRF
• Finished processing: /Users/ricl/Chenxi/OpenSearch-Dashboards/plugins/alerting-d (2 seconds)
  ashboards-plugin/cypress/videos/composite_level_monitor_spe
  c.js.mp4

────────────────────────────────────────────────────────────────────────────────────────────────────

Running: document_level_monitor_spec.js (7 of 9)

DocumentLevelMonitor
can be created
✓ by extraction query editor (32911ms)
✓ by visual editor (50851ms)
can be updated
when defined with extraction query editor
✓ with a new trigger (13945ms)
when defined with visual editor
✓ with a new query and a new trigger (21817ms)
✓ with only 1 index (11381ms)

5 passing (2m)

(Results)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 5 │
│ Passing: 5 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: true │
│ Duration: 2 minutes, 13 seconds │
│ Spec Ran: document_level_monitor_spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

(Video)

• Started processing: Compressing to 32 CRF
  Compression progress: 99%
• Finished processing: /Users/ricl/Chenxi/OpenSearch-Dashboards/plugins/alerting-d (11 seconds)
  ashboards-plugin/cypress/videos/document_level_monitor_spec
  .js.mp4

────────────────────────────────────────────────────────────────────────────────────────────────────

Running: monitors_dashboard_spec.js (8 of 9)

Monitors dashboard page
✓ Displays expected number of alerts (18314ms)

1 passing (29s)

(Results)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 1 │
│ Passing: 1 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: true │
│ Duration: 29 seconds │
│ Spec Ran: monitors_dashboard_spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

(Video)

• Started processing: Compressing to 32 CRF
• Finished processing: /Users/ricl/Chenxi/OpenSearch-Dashboards/plugins/alerting-d (2 seconds)
  ashboards-plugin/cypress/videos/monitors_dashboard_spec.js.
  mp4

────────────────────────────────────────────────────────────────────────────────────────────────────

Running: query_level_monitor_spec.js (9 of 9)

Query-Level Monitors
can be created
✓ by extraction query (14084ms)
can be updated
✓ by changing the name (7027ms)
✓ to have multiple indices (15228ms)
can be deleted
✓ from "Actions" menu (3449ms)
can be searched
✓ by name (10763ms)
can have triggers
✓ with names that contain periods (65495ms)
schedule component displays as intended
✓ for an interval schedule (9596ms)
✓ for a cron expression schedule (6428ms)

8 passing (2m)

(Results)

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Tests: 8 │
│ Passing: 8 │
│ Failing: 0 │
│ Pending: 0 │
│ Skipped: 0 │
│ Screenshots: 0 │
│ Video: true │
│ Duration: 2 minutes, 16 seconds │
│ Spec Ran: query_level_monitor_spec.js │
└────────────────────────────────────────────────────────────────────────────────────────────────┘

(Video)

• Started processing: Compressing to 32 CRF
  Compression progress: 77%
• Finished processing: /Users/ricl/Chenxi/OpenSearch-Dashboards/plugins/alerting-d (14 seconds)
  ashboards-plugin/cypress/videos/query_level_monitor_spec.js
  .mp4

====================================================================================================

(Run Finished)

   Spec                                              Tests  Passing  Failing  Pending  Skipped  

┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✔ acknowledge_alerts_modal_spec.js 01:44 3 3 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ alert_spec.js 02:32 5 5 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ alerts_dashboard_flyout_spec.js 01:33 2 2 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ bucket_level_monitor_spec.js 01:32 4 4 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ cluster_metrics_monitor_spec.js 00:59 6 6 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ composite_level_monitor_spec.js 00:29 2 2 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ document_level_monitor_spec.js 02:13 5 5 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ monitors_dashboard_spec.js 00:29 1 1 - - - │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ query_level_monitor_spec.js 02:16 8 8 - - - │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
✔ All specs passed! 13:51 36 36 - - -

✨ Done in 936.95s.
Richards-MacBook-Pro:alerting-dashboards-plugin ricl$