Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.sh to take platform parameter. #240

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Nov 12, 2021

Signed-off-by: Marc Handalian handalm@amazon.com

Description of changes:
Update build.sh to include optional platform parameter. This is sent by the build workflow so is required to be present.

CheckList:
[ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Marc Handalian <handalm@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #240 (6268629) into main (8b337e7) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #240      +/-   ##
============================================
+ Coverage     78.63%   78.64%   +0.01%     
  Complexity      215      215              
============================================
  Files           173      173              
  Lines          6959     6959              
  Branches        912      912              
============================================
+ Hits           5472     5473       +1     
  Misses         1002     1002              
+ Partials        485      484       -1     
Impacted Files Coverage Δ
...ain/kotlin/org/opensearch/alerting/AlertService.kt 78.53% <0.00%> (ø)
.../kotlin/org/opensearch/alerting/core/JobSweeper.kt 72.25% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a35bb6...6268629. Read the comment docs.

@dblock dblock requested a review from peternied November 12, 2021 14:50
@peternied peternied merged commit 15bb70b into opensearch-project:main Nov 12, 2021
lezzago pushed a commit to lezzago/alerting-opensearch that referenced this pull request Dec 14, 2021
Signed-off-by: Marc Handalian <handalm@amazon.com>
lezzago pushed a commit to lezzago/alerting-opensearch that referenced this pull request Dec 15, 2021
Signed-off-by: Marc Handalian <handalm@amazon.com>
dblock pushed a commit that referenced this pull request Dec 29, 2021
* Update build.sh to take platform parameter. (#240)

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add a codeowners file (#235)

Signed-off-by: CEHENKLE <henkle@amazon.com>

* Update README badge links to refer to OpenSearch Alerting (#244)

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Bumps to version 1.3 (#248)

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update GitHub Actions to run on all branches (#256)

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update sweep logic to re-schedule unchanged jobs when SWEEPER_ENABLED is toggled (#243)

* Update sweep logic to re-schedule unchanged jobs when SWEEPER_ENABLED is toggled

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update isMonitorScheduled to not use var for returned boolean

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

Co-authored-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: CEHENKLE <henkle@amazon.com>
Co-authored-by: Mohammad Qureshi <qreshi@amazon.com>
Co-authored-by: Clay Downs <downsrob@amazon.com>
AWSHurneyt pushed a commit to AWSHurneyt/OpenSearch-Alerting that referenced this pull request Mar 30, 2022
* Update build.sh to take platform parameter. (opensearch-project#240)

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add a codeowners file (opensearch-project#235)

Signed-off-by: CEHENKLE <henkle@amazon.com>

* Update README badge links to refer to OpenSearch Alerting (opensearch-project#244)

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Bumps to version 1.3 (opensearch-project#248)

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Update GitHub Actions to run on all branches (opensearch-project#256)

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update sweep logic to re-schedule unchanged jobs when SWEEPER_ENABLED is toggled (opensearch-project#243)

* Update sweep logic to re-schedule unchanged jobs when SWEEPER_ENABLED is toggled

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update isMonitorScheduled to not use var for returned boolean

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

Co-authored-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: CEHENKLE <henkle@amazon.com>
Co-authored-by: Mohammad Qureshi <qreshi@amazon.com>
Co-authored-by: Clay Downs <downsrob@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants