Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCO Check Workflow #103

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Conversation

amitgalitz
Copy link
Member

Signed-of-by: Amit Galitzky amgalitz@amazon.com

Description

Adding working flow to check whether commits are signed as per DCO.

Issues Resolved

#98

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@ohltyler ohltyler linked an issue Oct 28, 2021 that may be closed by this pull request
2 tasks
@ohltyler ohltyler added the v1.2.0 Version 1.2.0 label Oct 28, 2021
@amitgalitz
Copy link
Member Author

@ohltyler Okay to merge already as all features are in or wait for version bump?

@ohltyler
Copy link
Member

ohltyler commented Nov 2, 2021

@ohltyler Okay to merge already as all features are in or wait for version bump?

Had one additional comment. Once that's addressed, I'm ok to approve, should be fine to merge before version bump.

@amitgalitz amitgalitz merged commit dceb540 into opensearch-project:main Nov 2, 2021
ohltyler pushed a commit to ohltyler/anomaly-detection-dashboards-plugin-1 that referenced this pull request Nov 8, 2021
* added dco workflow check

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>

* added dco workflow check

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
ohltyler pushed a commit that referenced this pull request Nov 9, 2021
* added dco workflow check

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>

* added dco workflow check

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@amitgalitz amitgalitz added the enhancement New feature or request label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.2.0 Version 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure DCO Workflow Check
2 participants