Fix e2e #116
Merged
Fix e2e #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
ohltyler
reviewed
Nov 5, 2021
| OPENSEARCH_DOCKER_IMAGE: opensearchstaging/opensearch | ||
| DASHBOARDS_DOCKER_IMAGE: opensearchstaging/opensearch-dashboards | ||
| DOCKER_TAG: 1.1.0 | ||
| OPENSEARCH_VERSION: '1.2.0-SNAPSHOT' | ||
| jobs: | ||
| test-with-security: | ||
| name: Run e2e tests with security |
There was a problem hiding this comment.
the regression here is now we're only testing with no security (this can be renamed). Part of the reason for using the docker images was that security was included. Is there a way to pull security dependencies from maven?
ohltyler
previously approved these changes
Nov 5, 2021
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
ylwu-amzn
approved these changes
Nov 5, 2021
ohltyler
pushed a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Nov 8, 2021
* no security enabled Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
1 task
amitgalitz
added
v1.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Galitzky amgalitz@amazon.com
Description
Fixed E2E workflow so it doesn't break everytime since it used to run based of a docker image which we don't use anymore. Instead of using docker I run Opensearch with AD plugin using the 1.2.0 Snapshot. Currently I didn't distinguish two different versions like we used to have with and without security.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.