Remove old copyright #118
Remove old copyright #118
Conversation
| @@ -1,18 +1,3 @@ | |||
| /* | |||
There was a problem hiding this comment.
Add new copyright header after removing this old one?
| @@ -1,27 +1,12 @@ | |||
| /* | |||
| @@ -1,18 +1,3 @@ | |||
| /* | |||
There was a problem hiding this comment.
Add new copyright header and check other files?
There was a problem hiding this comment.
Got it will check other files, didn't realize some files didn't have the other headers
There was a problem hiding this comment.
@ylwu-amzn @ohltyler Should I add a copyright header to files like package.json and .prettierrc also? A few more config files never had at any point a copyright header
There was a problem hiding this comment.
If possible, sure. I remember there was some issue adding comments to some of those files, but if it compiles and works, go ahead.
There was a problem hiding this comment.
You are right, can't add comments to json files and some others
|
@amitgalitz regarding reformatting changes - were you able to find a VS Code extension that is equivalent to running |
I still have not been able to find why the extension is slightly off from the cli or a different extension where I can guarantee output is 100% the same. |
amitgalitz
force-pushed
the
remove_old_copyright
branch
from
61e56b6 to
3f2cf6d
Compare
|
Reviewed each file that was changed to make sure nothing else was deleted except copyright and that each file that was changed has the new header |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
amitgalitz
force-pushed
the
remove_old_copyright
branch
from
3f2cf6d to
bf1fd15
Compare
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
amitgalitz
force-pushed
the
remove_old_copyright
branch
from
bf1fd15 to
f1d337a
Compare
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-of-by: Amit Galitzky
Description
Issues Resolved
#101
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.