Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support create monitor with custom result index #123

Merged

Conversation

ylwu-amzn
Copy link
Contributor

Signed-off-by: Yaliang Wu ylwu@amazon.com

When user click set up alerts button on detector realtime result page, we need to pass AD result index to monitor creation page, so the monitor can query correct AD result index.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the changes!

Copy link
Member

@amitgalitz amitgalitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me

@ylwu-amzn ylwu-amzn merged commit c83b138 into opensearch-project:main Nov 8, 2021
ohltyler pushed a commit to ohltyler/anomaly-detection-dashboards-plugin-1 that referenced this pull request Nov 9, 2021
ohltyler pushed a commit that referenced this pull request Nov 9, 2021
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@amitgalitz amitgalitz added v1.2.0 Version 1.2.0 bug Something isn't working labels Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.2.0 Version 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants