Fix bug of HC historical results not auto-refreshing #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ylwu-amzn
approved these changes
Nov 10, 2021
amitgalitz
approved these changes
Nov 10, 2021
ohltyler
added a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Nov 10, 2021
…ect#131) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
added a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Nov 10, 2021
…ect#131) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
added a commit
that referenced
this pull request
Nov 10, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
added a commit
that referenced
this pull request
Nov 10, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
Description
Fixes a bug where heatmap chart data doesn't auto-refresh properly in the historical scenario. Note that the data would still show fine if the page was refreshed (switched tabs, etc.).
The bug was that the entity-level anomaly summaries weren't being fetched during the auto-refresh codepath, and were always being passed as an empty list. The heatmap chart data is prepared using the summaries, and so because the summaries were always empty, the heatmap chart data was always subsequently empty.
The fix is to add a call to fetch the entity summaries (
fetchHCAnomalySummaries()) after fetching the raw results (fetchRawAnomalyResults()) inAnomalyHistory, which is rendered as a child component inHistoricalDetectorResults. Note thatfetchRawAnomalyResults()is called in a custom hook (see lines 353-363), which is listening on changes forprops.detector. And,props.detectoris changed during auto refresh, where the task progress is updated (props.detector.taskProgress), hence triggering this whole workflow.Confirmed nothing breaks after historical job is
FINISHED/STOPPED, as well as real-time scenarios.Issues Resolved
Closes #130
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.