-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc links to point to OpenSearch #30
Conversation
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Searched "opendistro.github" in the branch |
Good catch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the change!
@@ -1,7 +1,7 @@ | |||
[](https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/actions?query=workflow%3A%22Unit+tests+workflow%22) | |||
[](https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/actions?query=workflow%3A%22E2E+tests+workflow%22) | |||
[](https://codecov.io/gh/opensearch-project/anomaly-detection-dashboards-plugin) | |||
[](https://opendistro.github.io/for-elasticsearch-docs/docs/ad/) | |||
[](https://docs-beta.opensearch.org/docs/ad/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we change the "beta" to "release" or something else later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely. That's why I refactored it into a constant (see second line of PR description).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
Description
Updates the documentation links to point to the new home for docs: https://docs-beta.opensearch.org/
Refactored the base doc link into a constant to make it easier to change in the future (e.g., going from
docs-beta.opensearch
->docs.opensearch
).Sanity tested on the UI to make sure they work.
Issues Resolved
Resolves #27
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.