Fix BWC for custom & simple filters #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
kaituo
approved these changes
Aug 16, 2021
ylwu-amzn
approved these changes
Aug 18, 2021
ohltyler
added a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Sep 1, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
added a commit
that referenced
this pull request
Sep 1, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
Description
Please see the previous PR describing the original filter changes for more details. This PR is to fix some missed cases where filters created from the old UI aren't rendering correctly on the new UI.
To handle backward compatibility, we need to pass some fields via props to the subcomponents so they can render correctly:
oldFilterType: there used to only be one filter type per detector. Now, the filter type is on a per-filter granularity, and each type is stored within each filter in the filters array.oldFilterQuery: the custom filter query used to be stored here. Now, the same field is repurposed in the new changes, but has a different meaning, since it is a dynamically built query based on each individually-created filter. SeeformikToFilterQuery()inpublic/pages/ReviewAndCreate/utils/helpers.tsfor details on how the new filter query is dynamically generated.Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.