Enable shingle in HCAD #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we hardcoded HCAD (including real-time and historical) shingle size to be one due to time constraints when releasing HCAD. This PR enabled shingling in HCAD on the frontend (backend PR: opensearch-project/anomaly-detection#187). Specifically, after this PR * both single-stream and HCAD detectors have a default shingle size of 8. * no special handling of HCAD detectors' shingle size. Testing done: 1. unit tests and cypress tests pass. 2. Manual testing to verify HCAD real-time and historical tasks use shingle eight by default and can use customized size. 3. Manual testing to verify preview uses shingle eight by default and can use the customized size.
|
LGTM! Will wait to approve after UX confirms the wording changes from "Window size" to "Shingle size" |
|
@ohltyler, I can do it in a separate PR. |
Sure, makes sense. |
ohltyler
approved these changes
Aug 24, 2021
ylwu-amzn
approved these changes
Aug 24, 2021
ohltyler
pushed a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Sep 1, 2021
Previously, we hardcoded HCAD (including real-time and historical) shingle size to be one due to time constraints when releasing HCAD. This PR enabled shingling in HCAD on the frontend (backend PR: opensearch-project/anomaly-detection#187). Specifically, after this PR * both single-stream and HCAD detectors have a default shingle size of 8. * no special handling of HCAD detectors' shingle size. Testing done: 1. unit tests and cypress tests pass. 2. Manual testing to verify HCAD real-time and historical tasks use shingle eight by default and can use customized size. 3. Manual testing to verify preview uses shingle eight by default and can use the customized size.
ohltyler
pushed a commit
that referenced
this pull request
Sep 1, 2021
Previously, we hardcoded HCAD (including real-time and historical) shingle size to be one due to time constraints when releasing HCAD. This PR enabled shingling in HCAD on the frontend (backend PR: opensearch-project/anomaly-detection#187). Specifically, after this PR * both single-stream and HCAD detectors have a default shingle size of 8. * no special handling of HCAD detectors' shingle size. Testing done: 1. unit tests and cypress tests pass. 2. Manual testing to verify HCAD real-time and historical tasks use shingle eight by default and can use customized size. 3. Manual testing to verify preview uses shingle eight by default and can use the customized size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we hardcoded HCAD (including real-time and historical) shingle size to be one due to time constraints when releasing HCAD. This PR enabled shingling in HCAD on the frontend (backend PR: opensearch-project/anomaly-detection#187). Specifically, after this PR
Testing done:
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.