Change single size description and fix related places #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changed the shingle size description. Specifically, 1) I replaced window size with shingle size as we used shingle in various places of https://opensearch.org/docs/monitoring-plugins/ad/index/ and our code. To be consistent, I changed to shingle. 2) We discourage the use of shingle size 1. AD with 1 value is not well defined, attribution is not useful (100% always) and expected value is not well defined. The recommendation makes the result more useful to the customer. 3) Updated the range of shingle size. 4) Changed to have one default shingle size 8. Don't differentiate HCAD and single-stream detectors. Testing done: 1. unit and e2e tests pass. 2. Manually checked the changed text showed correctly.
ashwinkumar12345
approved these changes
Aug 26, 2021
ohltyler
pushed a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Sep 1, 2021
…oject#76) * Change single size description and fix related places This PR changed the shingle size description. Specifically, 1) I replaced window size with shingle size as we used shingle in various places of https://opensearch.org/docs/monitoring-plugins/ad/index/ and our code. To be consistent, I changed to shingle. 2) We discourage the use of shingle size 1. AD with 1 value is not well defined, attribution is not useful (100% always) and expected value is not well defined. The recommendation makes the result more useful to the customer. 3) Updated the range of shingle size. 4) Changed to have one default shingle size 8. Don't differentiate HCAD and single-stream detectors. Testing done: 1. unit and e2e tests pass. 2. Manually checked the changed text showed correctly.
ohltyler
pushed a commit
that referenced
this pull request
Sep 1, 2021
* Change single size description and fix related places This PR changed the shingle size description. Specifically, 1) I replaced window size with shingle size as we used shingle in various places of https://opensearch.org/docs/monitoring-plugins/ad/index/ and our code. To be consistent, I changed to shingle. 2) We discourage the use of shingle size 1. AD with 1 value is not well defined, attribution is not useful (100% always) and expected value is not well defined. The recommendation makes the result more useful to the customer. 3) Updated the range of shingle size. 4) Changed to have one default shingle size 8. Don't differentiate HCAD and single-stream detectors. Testing done: 1. unit and e2e tests pass. 2. Manually checked the changed text showed correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changed the shingle size description. Specifically,
Testing done:
Before:
After:
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.