Bug fixes for single flow feature #77
Conversation
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
|
E2E tests failing due to upstream changes in Dashboards which bumped the version in the Will fix in a separate PR to run against the explicit |
| get(detector, 'taskState') === DETECTOR_STATE.INIT; | ||
| const runningJobsAsString = | ||
| isRTJobRunning && isHistoricalJobRunning | ||
| ? 'detector and historical analysis' |
There was a problem hiding this comment.
should we use sth like "real-time" instead of detector? I think the main contribution of single flow is to let real time and historical analyses share a detector.
There was a problem hiding this comment.
Right, so the frontend still primarily corresponds starting and stopping a "Detector" with the real-time aspect of it, like how it was before. Single flow basically merged historical detectors into a detector's "Historical analysis". The UI & wording is primarily around this idea now, where you create a detector, and you can either (1) run it (which by default is real-time), and/or (2) run a historical analysis.
This wording was gone through UX and tech writer reviews. Let me know if you still have concerns.
| @@ -575,6 +575,7 @@ export const AnomalyHistory = (props: AnomalyHistoryProps) => { | |||
| detector={props.detector} | |||
| monitor={props.monitor} | |||
| isHCDetector={isHCDetector} | |||
| isHistorical={props.isHistorical} | |||
There was a problem hiding this comment.
Can you point me the code link to 'The detector was stopped' error message? Cannot find it and thus cannot link between isHistorical and the appearance of 'The detector was stopped'.
There was a problem hiding this comment.
Just asking, can we fix the issue "AD result chart of historical HC shows detector stopped message" by adding this line?
There was a problem hiding this comment.
@kaituo the annotations are created in disabledHistoryAnnotations, which is used in AnomalyDetailsChart, which is called in AnomaliesChart, which is called in AnomalyHistory
@ylwu-amzn Yes, see point 2 in description
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
Description
This PR fixes 2 bugs found when testing out the single flow feature:
RUNNINGwhen initially opened, but was changed toFINISHEDsoon after).isHistoricalprop to the relevant components, which will hide these annotations if the chart is being rendered in a historical context.Testing:
Screenshots of an example where both realtime and historical jobs were running:
Updated wording in modal:
Updated wording in toast:
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.