Enable zooming in HC entity charts #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ylwu-amzn
reviewed
Aug 30, 2021
| } | ||
| } | ||
| } | ||
| onBrushEnd={(brushArea: XYBrushArea) => { |
There was a problem hiding this comment.
For single-entity detector, the zooming will dynamically sample anomaly results and show. For example, if the date range is big and contains too many data points, we will sample 1000 anomaly results points and show them. For HC detector, is it the same logic?
There was a problem hiding this comment.
Yes, we bucketize the results the same way as the single entity. It is abstracted such that the results are handled without context of single entity vs. multi entity, real-time vs. historical, etc.
The bulk of that logic is done in AnomalyHistory if you're interested.
ylwu-amzn
approved these changes
Aug 31, 2021
kaituo
approved these changes
Aug 31, 2021
ohltyler
added a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Sep 1, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
added a commit
that referenced
this pull request
Sep 1, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
Description
This PR adds zooming capabilities to the anomaly chart when selecting a heatmap cell for high-cardinality detectors.
Changes include:
AnomaliesDetailChart: Allowing zooming for high-cardinality detectorsFeatureBreakDown: Setting the date range based on the passed-in date range (which iszoomRange) instead of the heatmap cell. This is so we can narrow the range if the user zooms, rather than leaving it at the heatmap cell's static range.AnomalyHistory: setting thezoomRangewhen a heatmap cell is selected or de-selected, to refresh any stored data in the components. This is needed sinceFeatureBreakDownnow relies on thezoomRangeto get the date range.AnomalyResultsTable: Only populate with anomalies when applicable. The two applicable cases are (1) non high-cardinality detectors and (2) high-cardinality detectors when a heatmap cell is selected. This had to be changed due to thezoomRangeallowing more results to be shown, so more filtering was needed.Testing:
Confirmed the zooming works, and updates the corresponding table and feature breakdown accordingly.
Confirmed that selecting different heatmap cells or de-selecting heatmap cells will clear the zoom range.
Confirmed it works for historical and real-time.
Confirmed it doesn't break the components for non-high-cardinality detectors.
Issues Resolved
#75
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.