Clear HC charts when the date range changes #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ylwu-amzn
approved these changes
Sep 1, 2021
kaituo
approved these changes
Sep 1, 2021
ohltyler
added a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Sep 2, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
added a commit
that referenced
this pull request
Sep 2, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
Description
Currently, if a user selects a heatmap cell, the (1) anomaly chart, (2) anomaly table, and (3) feature chart are populated below. When the user changes any of the heatmap chart filters (top 10 / top 20 / top 30, sort by # occurrences / sort by severity, etc.), the data in these 3 components are cleared, since new cells will be generated, and the previously-selected one may not be available anymore.
However, changing the date range will not clear the state, even though it is also directly affecting the heatmap chart, and could lead to confusing UI if the results aren't cleared. This PR fixes that by clearing data when the date range is changed.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.