Update several minor things from opendistro to opensearch #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex <pengsun@amazon.com>
Signed-off-by: Alex <pengsun@amazon.com>
Signed-off-by: Alex <pengsun@amazon.com>
latest code which is requred to support the setting change. Signed-off-by: Alex <pengsun@amazon.com>
… 1.0.0-beta1 to 1.x 2. Update the code import from opendistro to opensearch 3. Update the CI workflow script to apply the dependencis version change. Signed-off-by: Alex <pengsun@amazon.com>
Signed-off-by: Alex <pengsun@amazon.com>
Signed-off-by: Alex <pengsun@amazon.com>
Signed-off-by: Alex <pengsun@amazon.com>
Signed-off-by: Alex <pengsun@amazon.com>
Signed-off-by: Alex <pengsun@amazon.com>
Signed-off-by: Alex <pengsun@amazon.com>
kaituo
approved these changes
May 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
============================================
+ Coverage 79.32% 79.36% +0.04%
- Complexity 2687 2690 +3
============================================
Files 243 243
Lines 11123 11123
Branches 1012 1012
============================================
+ Hits 8823 8828 +5
+ Misses 1882 1879 -3
+ Partials 418 416 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| public static final String AD_THREAD_POOL_NAME = "ad-threadpool"; | ||
| public static final String AD_BATCH_TASK_THREAD_POOL_NAME = "ad-batch-task-threadpool"; | ||
| public static final String AD_JOB_TYPE = "opendistro_anomaly_detector"; | ||
| public static final String AD_JOB_TYPE = "opensearch_anomaly_detector"; |
There was a problem hiding this comment.
I think this might be a problem.
Job Scheduler uses this identifier to understand what job it is.
If an old index of job scheduler exists from ODFE, and the cluster is upgraded to OpenSearch, the new job scheduler might not find the right place to run the job for AD.
Adding @ylwu-amzn to the conversation.
There was a problem hiding this comment.
Thank you for the comments!
I have submitted another commit to change this job type back.
There was a problem hiding this comment.
Thanks @spbjss, we should document this in the backward compatibility issue!
Signed-off-by: Alex <pengsun@amazon.com>
saratvemulapalli
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update several minor things from opendistro to opensearch
Issues Resolved
#40
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.