Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] fix security-analytics alerting findings api integration #293

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport eaa50c4 from #292

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit eaa50c4)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team October 20, 2022 01:27
@sbcd90 sbcd90 requested a review from eirsep October 20, 2022 01:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #293 (43a3639) into 2.x (40404e2) will increase coverage by 0.05%.
The diff coverage is 17.64%.

@@             Coverage Diff              @@
##                2.x     #293      +/-   ##
============================================
+ Coverage     71.62%   71.67%   +0.05%     
  Complexity      683      683              
============================================
  Files           110      110              
  Lines          4542     4537       -5     
  Branches        606      604       -2     
============================================
- Hits           3253     3252       -1     
+ Misses         1038     1034       -4     
  Partials        251      251              
Impacted Files Coverage Δ
...rch/commons/alerting/action/GetFindingsResponse.kt 18.75% <0.00%> (+2.08%) ⬆️
...ensearch/commons/alerting/model/FindingDocument.kt 0.00% <0.00%> (ø)
...ensearch/commons/alerting/model/FindingWithDocs.kt 8.57% <33.33%> (-0.81%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 merged commit c1fdd47 into 2.x Oct 20, 2022
@github-actions github-actions bot deleted the backport/backport-292-to-2.x branch October 20, 2022 01:32
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…project#292) (opensearch-project#293)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants