Removes comments from deployment files #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Signed-off-by: Huy Nguyen <wronghuy@amazon.com>
bandinib-amzn
approved these changes
Aug 2, 2022
CCongWang
approved these changes
Aug 3, 2022
seraphjiang
pushed a commit
to seraphjiang/dashboards-anywhere
that referenced
this pull request
Oct 22, 2022
* Removed commented code from deployment files Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Added newline after the dashboards.yaml Signed-off-by: Huy Nguyen <wronghuy@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Huy Nguyen wronghuy@amazon.com
Description
This PR removes unnecessary commented code from deployment files, following best practices.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.