Integrate sidecar service #164
Merged
+406
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depending on opensearch-project/OpenSearch-Dashboards#5920, so CI would fail for now. |
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
raintygao
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
wanglam
as code owners
Signed-off-by: tygao <tygao@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
+ Coverage 89.82% 90.07% +0.24%
==========================================
Files 52 54 +2
Lines 1396 1441 +45
Branches 340 347 +7
==========================================
+ Hits 1254 1298 +44
- Misses 140 141 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
wanglam
reviewed
Mar 18, 2024
| // mock sidecar open,hide and show | ||
| jest.spyOn(coreContextExports, 'useCore').mockReturnValue({ | ||
| overlays: { | ||
| // @ts-ignore |
There was a problem hiding this comment.
Shall we add some comments to show why we ignore here?
There was a problem hiding this comment.
I think most test cases are similar, we don't need to mock all values returned in useCore, we just mock something needed in the test case.
wanglam
reviewed
Mar 18, 2024
wanglam
reviewed
Mar 18, 2024
| @@ -119,12 +122,36 @@ export const HeaderChatButton = (props: HeaderChatButtonProps) => { | |||
| } | |||
| }; | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
Shall we move useEffect to the bottom of useCallback?
There was a problem hiding this comment.
Do you mean setMountPoint? I dont think declaration order will have any difference because SetMountPoint will always excute after sidecar().open().
Signed-off-by: tygao <tygao@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
* integrate sidecar poc Signed-off-by: tygao <tygao@amazon.com> * update sidecar menu Signed-off-by: tygao <tygao@amazon.com> * add portal log Signed-off-by: tygao <tygao@amazon.com> * update portal Signed-off-by: tygao <tygao@amazon.com> * keep sidecar size consistent when switching between right and left Signed-off-by: tygao <tygao@amazon.com> * update Signed-off-by: tygao <tygao@amazon.com> * add test subj for icon menu Signed-off-by: tygao <tygao@amazon.com> * remove extra change Signed-off-by: tygao <tygao@amazon.com> * remove core provider Signed-off-by: tygao <tygao@amazon.com> * update tests and add tests for sidecar icon menu Signed-off-by: tygao <tygao@amazon.com> * doc: update changelog and release note Signed-off-by: tygao <tygao@amazon.com> * doc: update release not Signed-off-by: tygao <tygao@amazon.com> * update Signed-off-by: tygao <tygao@amazon.com> * fix wrong enum value Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> (cherry picked from commit a4f210c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
raintygao
pushed a commit
that referenced
this pull request
Mar 19, 2024
* integrate sidecar poc Signed-off-by: tygao <tygao@amazon.com> * update sidecar menu Signed-off-by: tygao <tygao@amazon.com> * add portal log Signed-off-by: tygao <tygao@amazon.com> * update portal Signed-off-by: tygao <tygao@amazon.com> * keep sidecar size consistent when switching between right and left Signed-off-by: tygao <tygao@amazon.com> * update Signed-off-by: tygao <tygao@amazon.com> * add test subj for icon menu Signed-off-by: tygao <tygao@amazon.com> * remove extra change Signed-off-by: tygao <tygao@amazon.com> * remove core provider Signed-off-by: tygao <tygao@amazon.com> * update tests and add tests for sidecar icon menu Signed-off-by: tygao <tygao@amazon.com> * doc: update changelog and release note Signed-off-by: tygao <tygao@amazon.com> * doc: update release not Signed-off-by: tygao <tygao@amazon.com> * update Signed-off-by: tygao <tygao@amazon.com> * fix wrong enum value Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> (cherry picked from commit a4f210c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate sidecar service in OSD
Issues Resolved
#156
opensearch-project/OpenSearch-Dashboards#5620
Depending on opensearch-project/OpenSearch-Dashboards#5920
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.