-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the assistant entry when there isn't data2summary agent #417
Hide the assistant entry when there isn't data2summary agent #417
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
- Coverage 87.46% 85.03% -2.44%
==========================================
Files 65 72 +7
Lines 1891 2105 +214
Branches 473 518 +45
==========================================
+ Hits 1654 1790 +136
- Misses 236 313 +77
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would like to have some unit test
4b00fdd
to
c9f4960
Compare
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
c9f4960
to
771fd18
Compare
@Qxisylolo would you mind to fix DCO failure according to https://github.com/opensearch-project/dashboards-assistant/pull/417/checks?check_run_id=37588070203 |
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
a069c8b
to
a944017
Compare
Fixed, thanks~ |
Description
This pr hides the assistant entry when there isn't data2summary agent
!! This pr is a hard dependency that should be merged after opensearch-project/OpenSearch-Dashboards#9277 has been merged.
has agent:


no agent:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.